* [PATCH] sections, ipvs: Remove useless __read_mostly for ipvs genl_ops
@ 2014-02-08 7:57 Andi Kleen
2014-02-13 7:05 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Andi Kleen @ 2014-02-08 7:57 UTC (permalink / raw)
To: netdev
Cc: linux-kernel, Andi Kleen, Wensong Zhang, Simon Horman,
Patrick McHardy, lvs-devel
const __read_mostly does not make any sense, because const
data is already read-only. Remove the __read_mostly
for the ipvs genl_ops. This avoids a LTO
section conflict compile problem.
Cc: Wensong Zhang <wensong@linux-vs.org>
Cc: Simon Horman <horms@verge.net.au>
Cc: Patrick McHardy <kaber@trash.net>
Cc: lvs-devel@vger.kernel.org
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
net/netfilter/ipvs/ip_vs_ctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
index 35be035..2a68a38 100644
--- a/net/netfilter/ipvs/ip_vs_ctl.c
+++ b/net/netfilter/ipvs/ip_vs_ctl.c
@@ -3580,7 +3580,7 @@ out:
}
-static const struct genl_ops ip_vs_genl_ops[] __read_mostly = {
+static const struct genl_ops ip_vs_genl_ops[] = {
{
.cmd = IPVS_CMD_NEW_SERVICE,
.flags = GENL_ADMIN_PERM,
--
1.8.5.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] sections, ipvs: Remove useless __read_mostly for ipvs genl_ops
2014-02-08 7:57 [PATCH] sections, ipvs: Remove useless __read_mostly for ipvs genl_ops Andi Kleen
@ 2014-02-13 7:05 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2014-02-13 7:05 UTC (permalink / raw)
To: Andi Kleen
Cc: netdev, linux-kernel, Wensong Zhang, Patrick McHardy, lvs-devel
On Sat, Feb 08, 2014 at 08:57:01AM +0100, Andi Kleen wrote:
> const __read_mostly does not make any sense, because const
> data is already read-only. Remove the __read_mostly
> for the ipvs genl_ops. This avoids a LTO
> section conflict compile problem.
Thanks Andi, applied to ipvs-next.
> Cc: Simon Horman <horms@verge.net.au>
> Cc: Patrick McHardy <kaber@trash.net>
> Cc: lvs-devel@vger.kernel.org
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> net/netfilter/ipvs/ip_vs_ctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
> index 35be035..2a68a38 100644
> --- a/net/netfilter/ipvs/ip_vs_ctl.c
> +++ b/net/netfilter/ipvs/ip_vs_ctl.c
> @@ -3580,7 +3580,7 @@ out:
> }
>
>
> -static const struct genl_ops ip_vs_genl_ops[] __read_mostly = {
> +static const struct genl_ops ip_vs_genl_ops[] = {
> {
> .cmd = IPVS_CMD_NEW_SERVICE,
> .flags = GENL_ADMIN_PERM,
> --
> 1.8.5.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-13 7:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-08 7:57 [PATCH] sections, ipvs: Remove useless __read_mostly for ipvs genl_ops Andi Kleen
2014-02-13 7:05 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).