From: Emil Goode <emilgoode@gmail.com>
To: "David S. Miller" <davem@davemloft.net>,
Ming Lei <ming.lei@canonical.com>,
Mark Brown <broonie@linaro.org>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Glen Turner <gdt@gdt.id.au>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Emil Goode <emilgoode@gmail.com>
Subject: [PATCH 2/2] net: asix: add missing flag to struct driver_info
Date: Mon, 10 Feb 2014 00:06:14 +0100 [thread overview]
Message-ID: <1391987174-21828-2-git-send-email-emilgoode@gmail.com> (raw)
In-Reply-To: <1391987174-21828-1-git-send-email-emilgoode@gmail.com>
The struct driver_info ax88178_info is assigned the function
asix_rx_fixup_common as it's rx_fixup callback. This means that
FLAG_MULTI_PACKET must be set as this function is cloning the
data and calling usbnet_skb_return. Not setting this flag leads
to usbnet_skb_return beeing called a second time from within
the rx_process function in the usbnet module.
Signed-off-by: Emil Goode <emilgoode@gmail.com>
Reported-by: Bjørn Mork <bjorn@mork.no>
---
drivers/net/usb/asix_devices.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
index 7ced4ed..19d8821 100644
--- a/drivers/net/usb/asix_devices.c
+++ b/drivers/net/usb/asix_devices.c
@@ -919,7 +919,7 @@ static const struct driver_info ax88178_info = {
.link_reset = ax88178_link_reset,
.reset = ax88178_reset,
.flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_LINK_INTR |
- FLAG_PARTIAL_RX_PKT,
+ FLAG_MULTI_PACKET | FLAG_PARTIAL_RX_PKT,
.rx_fixup = asix_rx_fixup_common,
.tx_fixup = asix_tx_fixup,
};
--
1.7.10.4
next prev parent reply other threads:[~2014-02-09 23:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-09 23:06 [PATCH 1/2 v2] usbnet: fix bad header length bug Emil Goode
2014-02-09 23:06 ` Emil Goode [this message]
2014-02-10 6:40 ` Oliver Neukum
[not found] ` <1392014458.21271.6.camel-B2T3B9s34ElbnMAlSieJcQ@public.gmane.org>
2014-02-10 12:00 ` Emil Goode
2014-02-10 12:22 ` Oliver Neukum
[not found] ` <1392034947.2082.30.camel-B2T3B9s34ElbnMAlSieJcQ@public.gmane.org>
2014-02-10 12:39 ` David Laight
2014-02-10 13:05 ` Bjørn Mork
2014-02-10 15:54 ` Emil Goode
2014-02-11 7:43 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391987174-21828-2-git-send-email-emilgoode@gmail.com \
--to=emilgoode@gmail.com \
--cc=broonie@linaro.org \
--cc=davem@davemloft.net \
--cc=gdt@gdt.id.au \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).