netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: liujunliang_ljl@163.com
Cc: davem@davemloft.net, horms@verge.net.au, romieu@fr.zoreil.com,
	gregkh@linuxfoundation.org, netdev@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	sunhecheng@vip.126.com
Subject: Re: [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 Device Driver Support
Date: Sun, 09 Feb 2014 18:58:32 -0800	[thread overview]
Message-ID: <1392001112.3178.15.camel@joe-AO722> (raw)
In-Reply-To: <1391755365-9202-1-git-send-email-liujunliang_ljl@163.com>

On Fri, 2014-02-07 at 14:42 +0800, liujunliang_ljl@163.com wrote:

> +		netdev_dbg(dev->net, "Write IPG,IPG1,IPG2 failed: %d", ret);
[]
> +	netdev_dbg(dev->net, "RX_CTL is 0x%04x after all initializations",
[]
> +	netdev_dbg(dev->net, "Medium Status : 0x%04x after all initializations",
[]
> +		netdev_dbg(dev->net, "Select PHY #1 failed: %d", ret);
[]
> +	netdev_dbg(dev->net, "RX_CTL is 0x%04x after software reset", rx_ctl);
[]
> +	netdev_dbg(dev->net, "RX_CTL is 0x%04x setting to 0x0000", rx_ctl);
[]
> +	memcpy(data->mac_addr, dev->net->dev_addr, ETH_ALEN);

ether_addr_copy

> +		netdev_err(dev->net, "Failed to power down PHY : %d", ret);
[]
> +		netdev_err(dev->net, "Failed to reset PHY: %d", ret);
[]
> +		netdev_err(dev->net, "Failed to power up PHY: %d", ret);
[]
> +		netdev_err(dev->net, "Failed to reset PHY: %d", ret);
[]
> +			netdev_err(dev->net, "set LINK LED failed : %d", ret);
[]
> +		netdev_dbg(dev->net, "Failed to read MAC address: %d", ret);
[]
> +		netdev_dbg(dev->net, "Select PHY #1 failed: %d", ret);
[]
> +	netdev_dbg(dev->net, "RX_CTL is 0x%04x after software reset", rx_ctl);
[]
> +	netdev_dbg(dev->net, "RX_CTL is 0x%04x setting to 0x0000", rx_ctl);
[]
> +	netdev_dbg(dev->net, "PHYID=0x%08x", phyid);

Please make sure all of the netdev_<level> uses have a '\n'
line termination.

  parent reply	other threads:[~2014-02-10  2:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-07  6:42 [PATCH] USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 Device Driver Support liujunliang_ljl
2014-02-10  2:08 ` David Miller
2014-02-10  2:58 ` Joe Perches [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-02-10  6:31 liujunliang_ljl
2014-02-11  0:53 ` David Miller
2014-02-10  5:33 liujunliang_ljl
     [not found] ` <1392010419-5217-1-git-send-email-liujunliang_ljl-9Onoh4P/yGk@public.gmane.org>
2014-02-10  5:47   ` Joe Perches
2014-02-12 10:12 ` Thierry Reding
2014-01-28  8:36 liujunliang_ljl
2014-01-28  8:59 ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392001112.3178.15.camel@joe-AO722 \
    --to=joe@perches.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=horms@verge.net.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=liujunliang_ljl@163.com \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    --cc=sunhecheng@vip.126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).