From: Oliver Neukum <oliver@neukum.org>
To: Emil Goode <emilgoode@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Ming Lei <ming.lei@canonical.com>,
Mark Brown <broonie@linaro.org>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Glen Turner <gdt@gdt.id.au>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2 v2] usbnet: fix bad header length bug
Date: Mon, 10 Feb 2014 07:40:58 +0100 [thread overview]
Message-ID: <1392014458.21271.6.camel@linux-fkkt.site> (raw)
In-Reply-To: <1391987174-21828-1-git-send-email-emilgoode@gmail.com>
On Mon, 2014-02-10 at 00:06 +0100, Emil Goode wrote:
> The AX88772B occasionally send rx packets that cross urb boundaries
> and the remaining partial packet is sent with no hardware header.
> When the buffer with a partial packet is of less number of octets
> than the value of hard_header_len the buffer is discarded by the
> usbnet module. This is causing dropped packages and error messages
> in dmesg.
>
> This can be reproduced by using ping with a packet size
> between 1965-1976.
Well, then how about simply removing the check?
It seems to have outlived its usefulness.
Regards
Oliver
next prev parent reply other threads:[~2014-02-10 6:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-09 23:06 [PATCH 1/2 v2] usbnet: fix bad header length bug Emil Goode
2014-02-09 23:06 ` [PATCH 2/2] net: asix: add missing flag to struct driver_info Emil Goode
2014-02-10 6:40 ` Oliver Neukum [this message]
[not found] ` <1392014458.21271.6.camel-B2T3B9s34ElbnMAlSieJcQ@public.gmane.org>
2014-02-10 12:00 ` [PATCH 1/2 v2] usbnet: fix bad header length bug Emil Goode
2014-02-10 12:22 ` Oliver Neukum
[not found] ` <1392034947.2082.30.camel-B2T3B9s34ElbnMAlSieJcQ@public.gmane.org>
2014-02-10 12:39 ` David Laight
2014-02-10 13:05 ` Bjørn Mork
2014-02-10 15:54 ` Emil Goode
2014-02-11 7:43 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392014458.21271.6.camel@linux-fkkt.site \
--to=oliver@neukum.org \
--cc=broonie@linaro.org \
--cc=davem@davemloft.net \
--cc=emilgoode@gmail.com \
--cc=gdt@gdt.id.au \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).