Netdev List
 help / color / mirror / Atom feed
From: Yuval Mintz <yuvalmin@broadcom.com>
To: <davem@davemloft.net>, <netdev@vger.kernel.org>
Cc: <ariele@broadcom.com>, Yuval Mintz <yuvalmin@broadcom.com>
Subject: [PATCH net-next 3/9] bnx2x: Remove unnecessary internal mem config
Date: Mon, 10 Feb 2014 17:16:56 +0200	[thread overview]
Message-ID: <1392045422-5437-4-git-send-email-yuvalmin@broadcom.com> (raw)
In-Reply-To: <1392045422-5437-1-git-send-email-yuvalmin@broadcom.com>

From: Ariel Elior <ariele@broadcom.com>

Latest FW performs this autonomously, makes this code surplus.

Signed-off-by: Ariel Elior <ariele@broadcom.com>
Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_fw_defs.h |  1 -
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c    | 12 ------------
 2 files changed, 13 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_fw_defs.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_fw_defs.h
index 84aecdf..95dc365 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_fw_defs.h
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_fw_defs.h
@@ -87,7 +87,6 @@
 	(IRO[156].base + ((vfId) * IRO[156].m1))
 #define CSTORM_VF_TO_PF_OFFSET(funcId) \
 	(IRO[150].base + ((funcId) * IRO[150].m1))
-#define TSTORM_ACCEPT_CLASSIFY_FAILED_OFFSET (IRO[204].base)
 #define TSTORM_APPROXIMATE_MATCH_MULTICAST_FILTERING_OFFSET(pfId) \
 	(IRO[203].base + ((pfId) * IRO[203].m1))
 #define TSTORM_ASSERT_LIST_INDEX_OFFSET	(IRO[102].base)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
index 72ff5d2..383b025 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
@@ -6005,18 +6005,6 @@ static void bnx2x_init_internal_common(struct bnx2x *bp)
 {
 	int i;
 
-	if (IS_MF_SI(bp))
-		/*
-		 * In switch independent mode, the TSTORM needs to accept
-		 * packets that failed classification, since approximate match
-		 * mac addresses aren't written to NIG LLH
-		 */
-		REG_WR8(bp, BAR_TSTRORM_INTMEM +
-			    TSTORM_ACCEPT_CLASSIFY_FAILED_OFFSET, 2);
-	else if (!CHIP_IS_E1(bp)) /* 57710 doesn't support MF */
-		REG_WR8(bp, BAR_TSTRORM_INTMEM +
-			    TSTORM_ACCEPT_CLASSIFY_FAILED_OFFSET, 0);
-
 	/* Zero this manually as its initialization is
 	   currently missing in the initTool */
 	for (i = 0; i < (USTORM_AGG_DATA_SIZE >> 2); i++)
-- 
1.8.1.227.g44fe835

  parent reply	other threads:[~2014-02-10 15:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-10 15:16 [PATCH net-next 0/9] bnx2x: Enhancements & semantic changes series Yuval Mintz
2014-02-10 15:16 ` [PATCH net-next 1/9] bnx2x: [Debug] change verbosity of some prints Yuval Mintz
2014-02-10 15:16 ` [PATCH net-next 2/9] bnx2x: Remove unused iov code Yuval Mintz
2014-02-10 15:16 ` Yuval Mintz [this message]
2014-02-10 15:16 ` [PATCH net-next 4/9] bnx2x: Semantic Validate vlan/mac changes Yuval Mintz
2014-02-10 15:16 ` [PATCH net-next 5/9] bnx2x: Add support in PF driver for RSC Yuval Mintz
2014-02-10 15:16 ` [PATCH net-next 6/9] bnx2x: Revise IOV vlan/mac validation Yuval Mintz
2014-02-10 15:17 ` [PATCH net-next 7/9] bnx2x: Fix bnx2x_panic_dump for VFs Yuval Mintz
2014-02-10 15:17 ` [PATCH net-next 8/9] bnx2x: (semantic) revise scheduling of sp_rtnl Yuval Mintz
2014-02-10 15:17 ` [PATCH net-next 9/9] bnx2x: utilize FW 7.8.19 Yuval Mintz
2014-02-10 22:32 ` [PATCH net-next 0/9] bnx2x: Enhancements & semantic changes series David Miller
  -- strict thread matches above, loose matches on Subject: below --
2014-02-12 16:19 Yuval Mintz
2014-02-12 16:19 ` [PATCH net-next 3/9] bnx2x: Remove unnecessary internal mem config Yuval Mintz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392045422-5437-4-git-send-email-yuvalmin@broadcom.com \
    --to=yuvalmin@broadcom.com \
    --cc=ariele@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox