From: Joe Perches <joe@perches.com>
To: Simon Wunderlich <sw@simonwunderlich.de>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-wireless@vger.kernel.org,
mathias.kretschmer@fokus.fraunhofer.de
Subject: Re: [net-next 3/3] cfg80211: add MPLS and 802.21 classification
Date: Thu, 13 Feb 2014 03:14:08 -0800 [thread overview]
Message-ID: <1392290048.2214.41.camel@joe-AO722> (raw)
In-Reply-To: <201402131146.01749.sw@simonwunderlich.de>
On Thu, 2014-02-13 at 11:46 +0100, Simon Wunderlich wrote:
Hi Simon
> > On Wed, 2014-02-12 at 11:53 +0100, Simon Wunderlich wrote:
> > > MPLS labels may contain traffic control information, which should be
> > > evaluated and used by the wireless subsystem if present.
[]
> > > diff --git a/net/wireless/util.c b/net/wireless/util.c
[]
> > > +#include <uapi/linux/mpls.h>
> >
> > Please try not to #include uapi files.
> why not? The packet definition header has been put in UAPI, so I need that
> there ... or should we move that to some place else? Other protocol definition
> headers like IP, udp, tcp have been defined in uapi to the same way, so I
> figured that would be the right position.
It seems the practice is to have another include/<net|linux>/mpls.h
file that #includes the <uapi/linux/mpls.h>
For instance, look at:
include/linux/udp.h
It does #include <uapi/linux/udp.h>
All the other kernel sources use
#include <linux/udp.h>
prev parent reply other threads:[~2014-02-13 11:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 10:53 [net-next 0/3] 802.21 and MPLS headers and classification Simon Wunderlich
[not found] ` <1392202386-8826-1-git-send-email-sw-2YrNx6rUIHYiY0qSoAWiAoQuADTiUCJX@public.gmane.org>
2014-02-12 10:53 ` [net-next 1/3] if_ether.h: add IEEE 802.21 Ethertype Simon Wunderlich
2014-02-12 10:53 ` [net-next 2/3] UAPI: add MPLS label stack definition Simon Wunderlich
2014-02-12 10:53 ` [net-next 3/3] cfg80211: add MPLS and 802.21 classification Simon Wunderlich
2014-02-12 11:49 ` Joe Perches
2014-02-13 10:46 ` Simon Wunderlich
2014-02-13 11:14 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392290048.2214.41.camel@joe-AO722 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mathias.kretschmer@fokus.fraunhofer.de \
--cc=netdev@vger.kernel.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox