From: "Stefan Sørensen" <stefan.sorensen@spectralink.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: <grant.likely@linaro.org>, <robh+dt@kernel.org>,
<mark.rutland@arm.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] dp83640: Get pin and master/slave configuration from DT
Date: Thu, 13 Feb 2014 15:23:23 +0100 [thread overview]
Message-ID: <1392301403.2585.11.camel@e37108.spectralink.com> (raw)
In-Reply-To: <20140211201917.GB4254@netboy>
On Tue, 2014-02-11 at 21:19 +0100, Richard Cochran wrote:
> > +- dp83640,slave: If present, this phy will be slave to another dp83640
> > + on the same mdio bus.
>
> Wouldn't it be more natural to have one "dp83640,master" property
> rather than multiple slave properties?
I wanted to keep the common case of a single phy simple, i.e. no need to
specify any master/slave properties.
> Most of these pr_err lines are a bit _way_ too long for coding style.
I will fix that in the next version.
Stefan
prev parent reply other threads:[~2014-02-13 14:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 15:29 [PATCH v2 0/2] dp83640: Get pin and master/slave configuration from DT Stefan Sørensen
2014-02-11 15:29 ` [PATCH v2 1/2] dp83640: Support a configurable number of periodic outputs Stefan Sørensen
2014-02-11 20:09 ` Richard Cochran
2014-02-13 14:21 ` Stefan Sørensen
2014-02-11 15:29 ` [PATCH v2 2/2] dp83640: Get pin and master/slave configuration from DT Stefan Sørensen
2014-02-11 20:19 ` Richard Cochran
2014-02-13 14:23 ` Stefan Sørensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392301403.2585.11.camel@e37108.spectralink.com \
--to=stefan.sorensen@spectralink.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).