netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wang Weidong <wangweidong1@huawei.com>
To: <acme@ghostprotocols.net>, <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>
Subject: [PATCH net-next 3/4] appletalk: convert printks to pr_<level>
Date: Fri, 14 Feb 2014 15:43:45 +0800	[thread overview]
Message-ID: <1392363826-8256-4-git-send-email-wangweidong1@huawei.com> (raw)
In-Reply-To: <1392363826-8256-1-git-send-email-wangweidong1@huawei.com>

Prefer pr_<level> then printk(LEVEL).

Signed-off-by: Wang Weidong <wangweidong1@huawei.com>
---
 net/appletalk/aarp.c |  2 +-
 net/appletalk/ddp.c  | 13 ++++++-------
 2 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/net/appletalk/aarp.c b/net/appletalk/aarp.c
index d1c55d8..9ec36ed 100644
--- a/net/appletalk/aarp.c
+++ b/net/appletalk/aarp.c
@@ -883,7 +883,7 @@ void __init aarp_proto_init(void)
 {
 	aarp_dl = register_snap_client(aarp_snap_id, aarp_rcv);
 	if (!aarp_dl)
-		printk(KERN_CRIT "Unable to register AARP with SNAP.\n");
+		pr_crit("Unable to register AARP with SNAP.\n");
 	setup_timer(&aarp_timer, aarp_expire_timeout, 0);
 	aarp_timer.expires  = jiffies + sysctl_aarp_expiry_time;
 	add_timer(&aarp_timer);
diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
index 06e0d19..9189d3c 100644
--- a/net/appletalk/ddp.c
+++ b/net/appletalk/ddp.c
@@ -704,9 +704,9 @@ static int atif_ioctl(int cmd, void __user *arg)
 		if ((dev->flags & IFF_POINTOPOINT) &&
 		    atalk_find_interface(sa->sat_addr.s_net,
 					 sa->sat_addr.s_node)) {
-			printk(KERN_DEBUG "AppleTalk: point-to-point "
-			       "interface added with "
-			       "existing address\n");
+			pr_debug("AppleTalk: point-to-point "
+				 "interface added with "
+				 "existing address\n");
 			add_route = 0;
 		}
 
@@ -768,8 +768,7 @@ static int atif_ioctl(int cmd, void __user *arg)
 		} else {
 			limit = ntohs(nr->nr_lastnet);
 			if (limit - ntohs(nr->nr_firstnet) > 4096) {
-				printk(KERN_WARNING "Too many routes/"
-				       "iface.\n");
+				pr_warn("Too many routes/iface.\n");
 				return -EINVAL;
 			}
 			if (add_route)
@@ -1329,8 +1328,8 @@ static int atalk_route_packet(struct sk_buff *skb, struct net_device *dev,
 		 * needs to be broadcast onto the default network?
 		 */
 		if (dev->type == ARPHRD_PPP)
-			printk(KERN_DEBUG "AppleTalk: didn't forward broadcast "
-					  "packet received from PPP iface\n");
+			pr_debug("AppleTalk: didn't forward broadcast "
+				 "packet received from PPP iface\n");
 		goto free_it;
 	}
 
-- 
1.7.12

  parent reply	other threads:[~2014-02-14  7:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-14  7:43 [PATCH net-next 0/4] appletalk: fix checkpatch errors or warning Wang Weidong
2014-02-14  7:43 ` [PATCH net-next 1/4] appletalk: fix checkpatch errors with space required or prohibited Wang Weidong
2014-02-14 21:21   ` David Miller
2014-02-14  7:43 ` [PATCH net-next 2/4] appletalk: fix checkpatch errors with foo* bar|foo * bar Wang Weidong
2014-02-14 21:21   ` David Miller
2014-02-14  7:43 ` Wang Weidong [this message]
2014-02-14 21:21   ` [PATCH net-next 3/4] appletalk: convert printks to pr_<level> David Miller
2014-02-14 21:45   ` Sergei Shtylyov
2014-02-15  1:19     ` Wang Weidong
2014-02-14  7:43 ` [PATCH net-next 4/4] appletalk: fix checkpatch error with indent Wang Weidong
2014-02-14 21:21   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392363826-8256-4-git-send-email-wangweidong1@huawei.com \
    --to=wangweidong1@huawei.com \
    --cc=acme@ghostprotocols.net \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).