From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Grant Grundler <grundler@parisc-linux.org>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: drivers/net: tulip_remove_one needs to call pci_disable_device()
Date: Fri, 14 Feb 2014 15:32:20 +0100 [thread overview]
Message-ID: <1392388340-6527-1-git-send-email-bigeasy@linutronix.de> (raw)
From: Ingo Molnar <mingo@elte.hu>
Otherwise the device is not completely shut down.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
The patch is from "Date: Fri, 3 Jul 2009 08:30:18 -0500" and has been
in -RT since. Now that I stumbled upon it and didn't notice anything -RT
specific, here it comes.
diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c
index add05f1..1642de7 100644
--- a/drivers/net/ethernet/dec/tulip/tulip_core.c
+++ b/drivers/net/ethernet/dec/tulip/tulip_core.c
@@ -1939,6 +1939,7 @@ static void tulip_remove_one(struct pci_dev *pdev)
pci_iounmap(pdev, tp->base_addr);
free_netdev (dev);
pci_release_regions (pdev);
+ pci_disable_device(pdev);
/* pci_power_off (pdev, -1); */
}
--
1.9.0.rc3
next reply other threads:[~2014-02-14 14:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 14:32 Sebastian Andrzej Siewior [this message]
2014-02-17 5:19 ` drivers/net: tulip_remove_one needs to call pci_disable_device() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392388340-6527-1-git-send-email-bigeasy@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=grundler@parisc-linux.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox