From: Ben Hutchings <ben@decadent.org.uk>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, stephen@networkplumber.org
Subject: Re: [PATCH net-next v2 3/3] sch_netem: replace magic numbers with enumerate in GE model
Date: Sun, 16 Feb 2014 12:44:30 +0000 [thread overview]
Message-ID: <1392554670.15615.93.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <1392345043-12208-4-git-send-email-yangyingliang@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 361 bytes --]
On Fri, 2014-02-14 at 10:30 +0800, Yang Yingliang wrote:
> Replace some magic numbers which describe states of GE model
> loss generator with enumerate.
[...]
The name GOOD_STATE should also be used in get_loss_clg() where
clgstate::state is initialised.
Ben.
--
Ben Hutchings
Any sufficiently advanced bug is indistinguishable from a feature.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
next prev parent reply other threads:[~2014-02-16 12:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 2:30 [PATCH net-next v2 0/3] sch_netem: some improvements and cleanups Yang Yingliang
2014-02-14 2:30 ` [PATCH net-next v2 1/3] sch_netem: return errcode before setting params Yang Yingliang
2014-02-14 2:30 ` [PATCH net-next v2 2/3] sch_netem: change some func's param from "struct Qdisc *" to "struct netem_sched_data *" Yang Yingliang
2014-02-14 2:30 ` [PATCH net-next v2 3/3] sch_netem: replace magic numbers with enumerate in GE model Yang Yingliang
2014-02-16 12:44 ` Ben Hutchings [this message]
2014-02-17 6:38 ` Yang Yingliang
2014-02-14 5:15 ` [PATCH net-next v2 0/3] sch_netem: some improvements and cleanups David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392554670.15615.93.camel@deadeye.wl.decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox