From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [net-next 05/14 v2] i40evf: fix up strings in init task Date: Wed, 19 Feb 2014 20:58:14 -0800 Message-ID: <1392872294.24844.25.camel@joe-AO722> References: <1392868178-7011-1-git-send-email-aaron.f.brown@intel.com> <1392868178-7011-2-git-send-email-aaron.f.brown@intel.com> <1392869350.24844.22.camel@joe-AO722> <1392871887.2629.10.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, Mitch Williams , netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com, Jesse Brandeburg To: Aaron Brown Return-path: Received: from smtprelay0215.hostedemail.com ([216.40.44.215]:53734 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752935AbaBTE6R (ORCPT ); Wed, 19 Feb 2014 23:58:17 -0500 In-Reply-To: <1392871887.2629.10.camel@localhost> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2014-02-19 at 20:51 -0800, Aaron Brown wrote: > On Wed, 2014-02-19 at 20:09 -0800, Joe Perches wrote: > > On Wed, 2014-02-19 at 19:49 -0800, Aaron Brown wrote: > > > Make sure errors are reported at the correct log level, quit printing > > > the function name every time, and make the messages more consistent in > > > format. > > [] > > > diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c [] > > + dev_info(&pdev->dev, "Invalid MAC address %pMAC, using random\n", > > > + adapter->hw.mac.addr); > > The "AC" after %pM is superfluous. > Thanks Joe, guess I'll be making another spin... Or send another patch after this one because there are 2 %pMAC uses in i40evf_main.c