From: Joe Perches <joe@perches.com>
To: Alexander Aring <alex.aring@gmail.com>
Cc: alex.bluesman.smirnov@gmail.com, dbaryshkov@gmail.com,
davem@davemloft.net, linux-zigbee-devel@lists.sourceforge.net,
netdev@vger.kernel.org, martin.townsend@xsilon.com
Subject: Re: [PATCH net-next 4/6] 6lowpan: fix some checkpatch issues
Date: Fri, 21 Feb 2014 08:58:57 -0800 [thread overview]
Message-ID: <1393001937.2594.18.camel@joe-AO722> (raw)
In-Reply-To: <1392995711-19563-5-git-send-email-alex.aring@gmail.com>
On Fri, 2014-02-21 at 16:15 +0100, Alexander Aring wrote:
> diff --git a/net/ieee802154/6lowpan_rtnl.c b/net/ieee802154/6lowpan_rtnl.c
[]
> @@ -484,8 +475,8 @@ lowpan_skb_fragmentation(struct sk_buff *skb, struct net_device *dev)
> err = lowpan_fragment_xmit(skb, head, header_length, len,
> offset, LOWPAN_DISPATCH_FRAGN);
> if (err) {
> - pr_debug("%s unable to send a subsequent FRAGN packet "
> - "(tag: %d, offset: %d", __func__, tag, offset);
> + pr_debug("%s unable to send a FRAGN packet.", __func__);
> + pr_debug("tag: %d, offset: %d", tag, offset);
No need for 2 pr_debug statements.
Better to coalesce the format pieces into a single string
adding the close parenthesis and a terminating newline.
pr_debug("%s: unable to send a subsequent FRAGN packet "(tag: %d, offset: %d)\n",
__func__, tag, offset);
next prev parent reply other threads:[~2014-02-21 16:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 15:15 [PATCH net-next 0/6] 6lowpan: reimplementation of fragmentation handling Alexander Aring
2014-02-21 15:15 ` [PATCH net-next 1/6] 6lowpan: add frag information struct Alexander Aring
2014-02-21 15:15 ` [PATCH net-next 3/6] 6lowpan: move 6lowpan.c to 6lowpan_rtnl.c Alexander Aring
2014-02-22 13:40 ` Ben Hutchings
[not found] ` <1393076452.15717.98.camel-nDn/Rdv9kqW9Jme8/bJn5UCKIB8iOfG2tUK59QYPAWc@public.gmane.org>
2014-02-22 14:03 ` Alexander Aring
2014-02-22 14:07 ` Ben Hutchings
[not found] ` <1393078035.15717.103.camel-nDn/Rdv9kqW9Jme8/bJn5UCKIB8iOfG2tUK59QYPAWc@public.gmane.org>
2014-02-22 14:25 ` Alexander Aring
[not found] ` <1392995711-19563-1-git-send-email-alex.aring-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-02-21 15:15 ` [PATCH net-next 2/6] 6lowpan: fix fragmentation on sending side Alexander Aring
2014-02-21 15:15 ` [PATCH net-next 4/6] 6lowpan: fix some checkpatch issues Alexander Aring
2014-02-21 16:58 ` Joe Perches [this message]
2014-02-21 17:15 ` Alexander Aring
2014-02-21 15:15 ` [PATCH net-next 5/6] net: ns: add ieee802154_6lowpan namespace Alexander Aring
2014-02-21 15:15 ` [PATCH net-next 6/6] 6lowpan: handling 6lowpan fragmentation via inet_frag api Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393001937.2594.18.camel@joe-AO722 \
--to=joe@perches.com \
--cc=alex.aring@gmail.com \
--cc=alex.bluesman.smirnov@gmail.com \
--cc=davem@davemloft.net \
--cc=dbaryshkov@gmail.com \
--cc=linux-zigbee-devel@lists.sourceforge.net \
--cc=martin.townsend@xsilon.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox