From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend@broadcom.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH 01/14] brcmfmac: add delay before unregistering the network device
Date: Wed, 26 Feb 2014 12:48:08 +0100 [thread overview]
Message-ID: <1393415288.4133.7.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <530DD131.50205@broadcom.com>
On Wed, 2014-02-26 at 12:34 +0100, Arend van Spriel wrote:
> > I'm not sure this isn't still possible? I don't know when DELLINK is
> > sent.
>
> Given the behaviour I would say before the netdev notifier, which may be
> considered wrong. It depends whether the notifier was intended for the
> kind of thing that cfg80211 is doing, ie. send a netlink event to
> user-space?
Well, I checked:
call_netdevice_notifiers(NETDEV_UNREGISTER, dev);
if (!dev->rtnl_link_ops ||
dev->rtnl_link_state == RTNL_LINK_INITIALIZED)
rtmsg_ifinfo(RTM_DELLINK, dev, ~0U, GFP_KERNEL);
so ... :)
johannes
next prev parent reply other threads:[~2014-02-26 11:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1393356639-19169-1-git-send-email-arend@broadcom.com>
[not found] ` <1393356639-19169-2-git-send-email-arend@broadcom.com>
[not found] ` <1393358376.4170.22.camel@jlt4.sipsolutions.net>
[not found] ` <530DAECD.8010405@broadcom.com>
[not found] ` <1393406278.4133.4.camel@jlt4.sipsolutions.net>
[not found] ` <530DB3BA.20106@broadcom.com>
[not found] ` <1393407473.4133.5.camel@jlt4.sipsolutions.net>
[not found] ` <530DC56E.9040202@broadcom.com>
[not found] ` <1393413044.4133.6.camel@jlt4.sipsolutions.net>
2014-02-26 11:34 ` [PATCH 01/14] brcmfmac: add delay before unregistering the network device Arend van Spriel
2014-02-26 11:48 ` Johannes Berg [this message]
2014-02-26 12:18 ` Arend van Spriel
2014-02-26 12:22 ` Johannes Berg
2014-02-26 12:35 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393415288.4133.7.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend@broadcom.com \
--cc=davem@davemloft.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).