From: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
To: Alexander Aring
<alex.aring-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH net-next v4 6/8] 6lowpan: fix some checkpatch issues
Date: Wed, 26 Feb 2014 09:24:56 -0800 [thread overview]
Message-ID: <1393435496.407.24.camel@joe-AO722> (raw)
In-Reply-To: <1393430712-11298-7-git-send-email-alex.aring-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Wed, 2014-02-26 at 17:05 +0100, Alexander Aring wrote:
> Detected with:
>
> ./scripts/checkpatch.pl --strict -f net/ieee802154/6lowpan_rtnl.c
Hello Alexander.
Can I suggest to you (and to David) that the
multiline comment style:
/*
* comment
*/
is fine and doesn't need correcting here at the
initial bits of a file before any actual code has
been written?
Assuming David agrees, I'll see about updating
checkpatch to avoid this warning at the beginning
of files.
> diff --git a/net/ieee802154/6lowpan_rtnl.c b/net/ieee802154/6lowpan_rtnl.c
[]
> @@ -1,10 +1,8 @@
> -/*
> - * Copyright 2011, Siemens AG
> +/* Copyright 2011, Siemens AG
> * written by Alexander Smirnov <alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> */
------------------------------------------------------------------------------
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
Customize your own dashboards, set traffic alerts and generate reports.
Network behavioral analysis & security monitoring. All-in-one tool.
http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
next prev parent reply other threads:[~2014-02-26 17:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 16:05 [PATCH net-next v4 0/8] 6lowpan: reimplementation of fragmentation handling Alexander Aring
2014-02-26 16:05 ` [PATCH net-next v4 2/8] 6lowpan: add uncompress header size function Alexander Aring
2014-02-26 16:10 ` David Laight
2014-02-26 16:20 ` Alexander Aring
2014-02-26 17:05 ` David Laight
2014-02-26 18:24 ` Joe Perches
2014-02-26 18:32 ` Alexander Aring
2014-02-26 18:35 ` Joe Perches
2014-02-26 18:56 ` David Miller
2014-02-26 16:05 ` [PATCH net-next v4 3/8] 6lowpan: fix fragmentation on sending side Alexander Aring
2014-02-26 16:05 ` [PATCH net-next v4 5/8] 6lowpan: move 6lowpan.c to 6lowpan_rtnl.c Alexander Aring
[not found] ` <1393430712-11298-1-git-send-email-alex.aring-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-02-26 16:05 ` [PATCH net-next v4 1/8] 6lowpan: add frag information struct Alexander Aring
2014-02-26 16:05 ` [PATCH net-next v4 4/8] 6lowpan: change tag type to __be16 Alexander Aring
2014-02-26 16:05 ` [PATCH net-next v4 6/8] 6lowpan: fix some checkpatch issues Alexander Aring
[not found] ` <1393430712-11298-7-git-send-email-alex.aring-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-02-26 17:24 ` Joe Perches [this message]
2014-02-26 18:59 ` David Miller
2014-02-26 16:05 ` [PATCH net-next v4 7/8] net: ns: add ieee802154_6lowpan namespace Alexander Aring
2014-02-26 16:05 ` [PATCH net-next v4 8/8] 6lowpan: handling 6lowpan fragmentation via inet_frag api Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393435496.407.24.camel@joe-AO722 \
--to=joe-6d6dil74uinbdgjk7y7tuq@public.gmane.org \
--cc=alex.aring-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox