netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Herrmann <dh.herrmann@gmail.com>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Kay Sievers <kay.sievers@vrfy.org>, Tom Gundersen <teg@jklm.no>,
	Johannes berg <johannes@sipsolutions.net>,
	linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
	David Herrmann <dh.herrmann@gmail.com>,
	Johannes Berg <johannes.berg@intel.com>
Subject: [PATCH 2/4] mac80211: set NET_NAME_USER for user-space created ifs
Date: Thu, 27 Feb 2014 15:47:12 +0100	[thread overview]
Message-ID: <1393512434-1325-3-git-send-email-dh.herrmann@gmail.com> (raw)
In-Reply-To: <1393512434-1325-1-git-send-email-dh.herrmann@gmail.com>

The nl80211 interface allows creating new netdevs from user-space. The
name is *always* provided by user-space, so we should set NET_NAME_USER to
provide that information via sysfs.

This allows udev to not rename dynamically created wifi devices (like wifi
P2P devices).

Cc: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
---
 net/mac80211/iface.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
index ce1c443..35561bd 100644
--- a/net/mac80211/iface.c
+++ b/net/mac80211/iface.c
@@ -1620,6 +1620,7 @@ int ieee80211_if_add(struct ieee80211_local *local, const char *name,
 					+ IEEE80211_ENCRYPT_HEADROOM;
 		ndev->needed_tailroom = IEEE80211_ENCRYPT_TAILROOM;
 
+		ndev->name_assign_type = NET_NAME_USER;
 		ret = dev_alloc_name(ndev, ndev->name);
 		if (ret < 0) {
 			free_netdev(ndev);
-- 
1.9.0

  parent reply	other threads:[~2014-02-27 14:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-27 14:47 [PATCH 0/4] Provide netdev naming-policy via sysfs David Herrmann
2014-02-27 14:47 ` [PATCH 1/4] net: add name_assign_type netdev attribute David Herrmann
2014-02-27 14:47 ` David Herrmann [this message]
2014-02-27 14:53   ` [PATCH 2/4] mac80211: set NET_NAME_USER for user-space created ifs Johannes Berg
2014-02-27 14:56     ` David Herrmann
2014-02-27 16:18       ` Johannes Berg
2014-02-27 17:14         ` David Herrmann
2014-02-27 14:47 ` [PATCH 3/4] ath6kl: set NET_NAME_USER for P2P ifs David Herrmann
2014-02-27 15:27   ` Kalle Valo
2014-02-27 16:13     ` Kalle Valo
2014-02-27 14:47 ` [PATCH 4/4] brcmfmac: " David Herrmann
2014-02-27 17:30   ` Arend van Spriel
2014-02-27 15:47 ` [PATCH 0/4] Provide netdev naming-policy via sysfs Tom Gundersen
2014-03-01 14:19   ` Tom Gundersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393512434-1325-3-git-send-email-dh.herrmann@gmail.com \
    --to=dh.herrmann@gmail.com \
    --cc=davem@davemloft.net \
    --cc=johannes.berg@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=teg@jklm.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).