From: Marc Kleine-Budde <mkl@pengutronix.de>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, linux-can@vger.kernel.org,
kernel@pengutronix.de, Marc Kleine-Budde <mkl@pengutronix.de>
Subject: [PATCH 7/8] can: flexcan: factor out soft reset into seperate funtion
Date: Mon, 3 Mar 2014 14:54:34 +0100 [thread overview]
Message-ID: <1393854875-8171-8-git-send-email-mkl@pengutronix.de> (raw)
In-Reply-To: <1393854875-8171-1-git-send-email-mkl@pengutronix.de>
This patch moves the soft reset into a seperate function.
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/flexcan.c | 26 +++++++++++++++++---------
1 file changed, 17 insertions(+), 9 deletions(-)
diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
index dff4fa4..61376ab 100644
--- a/drivers/net/can/flexcan.c
+++ b/drivers/net/can/flexcan.c
@@ -363,6 +363,21 @@ static int flexcan_chip_unfreeze(struct flexcan_priv *priv)
return 0;
}
+static int flexcan_chip_softreset(struct flexcan_priv *priv)
+{
+ struct flexcan_regs __iomem *regs = priv->base;
+ unsigned int timeout = FLEXCAN_TIMEOUT_US / 10;
+
+ flexcan_write(FLEXCAN_MCR_SOFTRST, ®s->mcr);
+ while (timeout-- && (flexcan_read(®s->mcr) & FLEXCAN_MCR_SOFTRST))
+ usleep_range(10, 20);
+
+ if (flexcan_read(®s->mcr) & FLEXCAN_MCR_SOFTRST)
+ return -ETIMEDOUT;
+
+ return 0;
+}
+
static int flexcan_get_berr_counter(const struct net_device *dev,
struct can_berr_counter *bec)
{
@@ -786,16 +801,9 @@ static int flexcan_chip_start(struct net_device *dev)
return err;
/* soft reset */
- flexcan_write(FLEXCAN_MCR_SOFTRST, ®s->mcr);
- udelay(10);
-
- reg_mcr = flexcan_read(®s->mcr);
- if (reg_mcr & FLEXCAN_MCR_SOFTRST) {
- netdev_err(dev, "Failed to softreset can module (mcr=0x%08x)\n",
- reg_mcr);
- err = -ENODEV;
+ err = flexcan_chip_softreset(priv);
+ if (err)
goto out_chip_disable;
- }
flexcan_set_bittiming(dev);
--
1.9.0
next prev parent reply other threads:[~2014-03-03 13:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 13:54 pull-request: can 2014-03-03 Marc Kleine-Budde
2014-03-03 13:54 ` [PATCH 1/8] can: flexcan: fix shutdown: first disable chip, then all interrupts Marc Kleine-Budde
2014-03-03 13:54 ` [PATCH 2/8] can: flexcan: flexcan_open(): fix error path if flexcan_chip_start() fails Marc Kleine-Budde
2014-03-03 13:54 ` [PATCH 3/8] can: flexcan: fix transition from and to low power mode in chip_{en,dis}able Marc Kleine-Budde
2014-03-03 13:54 ` [PATCH 4/8] can: flexcan: factor out transceiver {en,dis}able into seperate functions Marc Kleine-Budde
2014-03-03 13:54 ` [PATCH 5/8] can: flexcan: fix transition from and to freeze mode in chip_{,un}freeze Marc Kleine-Budde
2014-03-03 13:54 ` [PATCH 6/8] can: flexcan: flexcan_remove(): add missing netif_napi_del() Marc Kleine-Budde
2014-03-03 13:54 ` Marc Kleine-Budde [this message]
2014-03-03 13:54 ` [PATCH 8/8] can: remove CAN FD compatibility for CAN 2.0 sockets Marc Kleine-Budde
2014-03-03 21:05 ` pull-request: can 2014-03-03 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393854875-8171-8-git-send-email-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).