* [PATCH] IPv6 exthedrs offload registration fixed
@ 2014-03-05 6:30 Anton Nayshtut
2014-03-06 21:37 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Anton Nayshtut @ 2014-03-05 6:30 UTC (permalink / raw)
To: David S. Miller, Alexey Kuznetsov, James Morris,
Hideaki YOSHIFUJI, Patrick McHardy
Cc: netdev, linux-kernel, Anton Nayshtut
Without this fix, ipv6_exthdrs_offload_init doesn't register IPPROTO_DSTOPTS
offload, but returns 0 (as the IPPROTO_ROUTING registration actually succeeds).
This then causes the ipv6_gso_segment to drop IPv6 packets with IPPROTO_DSTOPTS
header.
The issue detected and the fix verified by running MS HCK Offload LSO test on
top of QEMU Windows guests, as this test sends IPv6 packets with
IPPROTO_DSTOPTS.
Signed-off-by: Anton Nayshtut <anton@swortex.com>
---
net/ipv6/exthdrs_offload.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv6/exthdrs_offload.c b/net/ipv6/exthdrs_offload.c
index cf77f3a..447a7fb 100644
--- a/net/ipv6/exthdrs_offload.c
+++ b/net/ipv6/exthdrs_offload.c
@@ -25,11 +25,11 @@ int __init ipv6_exthdrs_offload_init(void)
int ret;
ret = inet6_add_offload(&rthdr_offload, IPPROTO_ROUTING);
- if (!ret)
+ if (ret)
goto out;
ret = inet6_add_offload(&dstopt_offload, IPPROTO_DSTOPTS);
- if (!ret)
+ if (ret)
goto out_rt;
out:
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] IPv6 exthedrs offload registration fixed
2014-03-05 6:30 [PATCH] IPv6 exthedrs offload registration fixed Anton Nayshtut
@ 2014-03-06 21:37 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-03-06 21:37 UTC (permalink / raw)
To: anton; +Cc: kuznet, jmorris, yoshfuji, kaber, netdev, linux-kernel
From: Anton Nayshtut <anton@swortex.com>
Date: Wed, 5 Mar 2014 08:30:08 +0200
> Without this fix, ipv6_exthdrs_offload_init doesn't register IPPROTO_DSTOPTS
> offload, but returns 0 (as the IPPROTO_ROUTING registration actually succeeds).
>
> This then causes the ipv6_gso_segment to drop IPv6 packets with IPPROTO_DSTOPTS
> header.
>
> The issue detected and the fix verified by running MS HCK Offload LSO test on
> top of QEMU Windows guests, as this test sends IPv6 packets with
> IPPROTO_DSTOPTS.
>
> Signed-off-by: Anton Nayshtut <anton@swortex.com>
Can't believe this was broken so obviously for so long :-)
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-06 21:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-05 6:30 [PATCH] IPv6 exthedrs offload registration fixed Anton Nayshtut
2014-03-06 21:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).