From: Joe Perches <joe@perches.com>
To: Edward Cree <ecree@solarflare.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, sshah@solarflare.com
Subject: Re: [PATCH net-next] sfc: Use ether_addr_copy and eth_broadcast_addr
Date: Wed, 05 Mar 2014 09:10:19 -0800 [thread overview]
Message-ID: <1394039419.3271.75.camel@joe-AO722> (raw)
In-Reply-To: <53170EF5.1030809@solarflare.com>
On Wed, 2014-03-05 at 11:48 +0000, Edward Cree wrote:
> On 04/03/14 20:36, David Miller wrote:
> >> diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c
[]
> >> @@ -162,8 +162,8 @@ static int efx_ef10_get_mac_address(struct efx_nic *efx, u8 *mac_address)
[]
> >> - memcpy(mac_address,
> >> - MCDI_PTR(outbuf, GET_MAC_ADDRESSES_OUT_MAC_ADDR_BASE), ETH_ALEN);
> >> + ether_addr_copy(mac_address,
> >> + MCDI_PTR(outbuf, GET_MAC_ADDRESSES_OUT_MAC_ADDR_BASE));
> > This is not indented correctly, the original code was.
> Oops, yes.
> After fixing that, checkpatch also complains about a couple of long
> lines (mcdi.c:1207-8). Am I right in thinking that it's being
> overzealous and is best ignored in this case?
Dunno if it's being overzealous, but anywhere overly
long variable names exist, (36+ chars here), wrapping to
80 columns is a bit limited.
Anyway, I wouldn't consider those long lines a problem.
prev parent reply other threads:[~2014-03-05 17:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 20:11 [PATCH net-next] sfc: Use ether_addr_copy and eth_broadcast_addr Edward Cree
2014-03-04 20:36 ` David Miller
2014-03-05 11:48 ` Edward Cree
2014-03-05 17:10 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394039419.3271.75.camel@joe-AO722 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=sshah@solarflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox