netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Anjali Singhai Jain <anjali.singhai@intel.com>,
	netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
	Catherine Sullivan <catherine.sullivan@intel.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 09/13] i40e: Remove a redundant filter addition
Date: Wed,  5 Mar 2014 20:21:40 -0800	[thread overview]
Message-ID: <1394079704-1108-10-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1394079704-1108-1-git-send-email-jeffrey.t.kirsher@intel.com>

From: Anjali Singhai Jain <anjali.singhai@intel.com>

Remove a redundant filter addition to stop FW complaints about a redundant
filter removal.

Change-ID: I22bef6b682bd8d43432557e6e2b3e73ffb27b985
Signed-off-by: Anjali Singhai Jain <anjali.singhai@intel.com>
Signed-off-by: Catherine Sullivan <catherine.sullivan@intel.com>
Tested-by: Kavindya Deegala <kavindya.s.deegala@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 724764f..5bb0670 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -1969,11 +1969,14 @@ static int i40e_vlan_rx_add_vid(struct net_device *netdev,
 
 	netdev_info(netdev, "adding %pM vid=%d\n", netdev->dev_addr, vid);
 
-	/* If the network stack called us with vid = 0, we should
-	 * indicate to i40e_vsi_add_vlan() that we want to receive
-	 * any traffic (i.e. with any vlan tag, or untagged)
+	/* If the network stack called us with vid = 0 then
+	 * it is asking to receive priority tagged packets with
+	 * vlan id 0.  Our HW receives them by default when configured
+	 * to receive untagged packets so there is no need to add an
+	 * extra filter for vlan 0 tagged packets.
 	 */
-	ret = i40e_vsi_add_vlan(vsi, vid ? vid : I40E_VLAN_ANY);
+	if (vid)
+		ret = i40e_vsi_add_vlan(vsi, vid);
 
 	if (!ret && (vid < VLAN_N_VID))
 		set_bit(vid, vsi->active_vlans);
-- 
1.8.3.1

  parent reply	other threads:[~2014-03-06  4:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-06  4:21 [net-next 00/13][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2014-03-06  4:21 ` [net-next 01/13] i40e: use ether_addr_equal_64bits Jeff Kirsher
2014-03-06  4:35   ` Joe Perches
2014-03-06  4:40     ` Jeff Kirsher
     [not found]       ` <CAP-MU4Nf=T-BZDpHnBzq8xcPf7CG3v2oMSD3fitAKXp=fP4XPw@mail.gmail.com>
2014-03-06 19:33         ` Jeff Kirsher
2014-03-06 20:45           ` David Miller
2014-03-06  4:21 ` [net-next 02/13] i40evf: Enable the ndo_set_features netdev op Jeff Kirsher
2014-03-06  4:21 ` [net-next 03/13] i40e: Flow Director sideband accounting Jeff Kirsher
2014-03-09 18:35   ` Ben Hutchings
2014-03-06  4:21 ` [net-next 04/13] i40e: Prevent overflow due to kzalloc Jeff Kirsher
2014-03-06  4:21 ` [net-next 05/13] i40e/i40evf: i40e implementation for skb_set_hash Jeff Kirsher
2014-03-06  4:21 ` [net-next 06/13] i40e: clean up comment style Jeff Kirsher
2014-03-06  4:21 ` [net-next 07/13] i40e: Remove a FW workaround for Number of MSIX vectors Jeff Kirsher
2014-03-06  4:21 ` [net-next 08/13] i40e: count timeout events Jeff Kirsher
2014-03-06  4:21 ` Jeff Kirsher [this message]
2014-03-06  4:21 ` [net-next 10/13] i40e: Fix static checker warning Jeff Kirsher
2014-03-06  4:21 ` [net-next 11/13] i40e: fix nvm version and remove firmware report Jeff Kirsher
2014-03-06  4:21 ` [net-next 12/13] i40e/i40evf: carefully fill tx ring Jeff Kirsher
2014-03-06  4:21 ` [net-next 13/13] i40e/i40evf: Bump pf&vf build versions Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394079704-1108-10-git-send-email-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=anjali.singhai@intel.com \
    --cc=catherine.sullivan@intel.com \
    --cc=davem@davemloft.net \
    --cc=gospo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).