From: Luca Coelho <luca-XPOmlcxoEMv1KXRcyAk9cg@public.gmane.org>
To: Surendra Patil <surendra.tux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org,
pavel-+ZI9xUNit7I@public.gmane.org,
pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
david.gnedt-rFfgOQFw6VLk7+2FdBfRIA@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] Drivers:net:wireless:ti:wl1251: Fixed Sparse invalid assignment warning
Date: Thu, 06 Mar 2014 10:55:12 +0200 [thread overview]
Message-ID: <1394096112.26326.1.camel@dubbel> (raw)
In-Reply-To: <1393921132-15950-1-git-send-email-surendra.tux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Tue, 2014-03-04 at 00:18 -0800, Surendra Patil wrote:
> Sparse warns about invalid assignment in
> drivers/net/wireless/ti/wl1251/cmd.c:451:42: warning: invalid assignment: |=
> drivers/net/wireless/ti/wl1251/cmd.c:451:42: left side has type restricted __le16
> drivers/net/wireless/ti/wl1251/cmd.c:451:42: right side has type int
> Hence type converted right side to __le16.
>
> Signed-off-by: Surendra Patil <surendra.tux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> drivers/net/wireless/ti/wl1251/cmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ti/wl1251/cmd.c b/drivers/net/wireless/ti/wl1251/cmd.c
> index 223649b..bf1fa18 100644
> --- a/drivers/net/wireless/ti/wl1251/cmd.c
> +++ b/drivers/net/wireless/ti/wl1251/cmd.c
> @@ -448,7 +448,7 @@ int wl1251_cmd_scan(struct wl1251 *wl, u8 *ssid, size_t ssid_len,
> * Note: This bug may be caused by the fw's DTIM handling.
> */
> if (is_zero_ether_addr(wl->bssid))
> - cmd->params.scan_options |= WL1251_SCAN_OPT_PRIORITY_HIGH;
> + cmd->params.scan_options |= cpu_to_le16(WL1251_SCAN_OPT_PRIORITY_HIGH);
> cmd->params.num_channels = n_channels;
> cmd->params.num_probe_requests = n_probes;
> cmd->params.tx_rate = cpu_to_le16(1 << 1); /* 2 Mbps */
AFAIR wl1251 is not really endianess-safe. I think there are lots of
other places where endianess macros should be added.
Nothing wrong with this patch, I'm just saying that while at it, maybe
someone could take care of all the endianess issues with wl1251? ;)
--
Luca.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-03-06 8:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 8:18 [PATCH] Drivers:net:wireless:ti:wl1251: Fixed Sparse invalid assignment warning Surendra Patil
2014-03-05 16:50 ` Pavel Machek
[not found] ` <1393921132-15950-1-git-send-email-surendra.tux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-03-06 8:55 ` Luca Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394096112.26326.1.camel@dubbel \
--to=luca-xpomlcxoemv1kxrcyak9cg@public.gmane.org \
--cc=david.gnedt-rFfgOQFw6VLk7+2FdBfRIA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=pavel-+ZI9xUNit7I@public.gmane.org \
--cc=surendra.tux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).