From: <erik.hugne@ericsson.com>
To: <netdev@vger.kernel.org>, <tipc-discussion@lists.sourceforge.net>,
<jon.maloy@ericsson.com>, <maloy@donjonn.com>
Cc: richard.alpe@ericsson.com
Subject: [PATCH net-next v3 6/6] tipc: don't log disabled tasklet handler errors
Date: Thu, 6 Mar 2014 14:40:21 +0100 [thread overview]
Message-ID: <1394113221-30100-7-git-send-email-erik.hugne@ericsson.com> (raw)
In-Reply-To: <1394113221-30100-1-git-send-email-erik.hugne@ericsson.com>
From: Erik Hugne <erik.hugne@ericsson.com>
Failure to schedule a TIPC tasklet with tipc_k_signal because the
tasklet handler is disabled is not an error. It means TIPC is
currently in the process of shutting down. We remove the error
logging in this case.
Signed-off-by: Erik Hugne <erik.hugne@ericsson.com>
Reviewed-by: Jon Maloy <jon.maloy@ericsson.com>
---
net/tipc/handler.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/tipc/handler.c b/net/tipc/handler.c
index e4bc8a2..1fabf16 100644
--- a/net/tipc/handler.c
+++ b/net/tipc/handler.c
@@ -58,7 +58,6 @@ unsigned int tipc_k_signal(Handler routine, unsigned long argument)
spin_lock_bh(&qitem_lock);
if (!handler_enabled) {
- pr_err("Signal request ignored by handler\n");
spin_unlock_bh(&qitem_lock);
return -ENOPROTOOPT;
}
--
1.8.3.2
------------------------------------------------------------------------------
Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce.
With Perforce, you get hassle-free workflows. Merge that actually works.
Faster operations. Version large binaries. Built-in WAN optimization and the
freedom to use Git, Perforce or both. Make the move to Perforce.
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
next prev parent reply other threads:[~2014-03-06 13:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 13:40 [PATCH net-next v3 0/6] tipc: refcount and memory leak fixes erik.hugne
2014-03-06 13:40 ` [PATCH net-next v3 1/6] tipc: allow connection shutdown callback to be invoked in advance erik.hugne
2014-03-06 13:40 ` [PATCH net-next v3 2/6] tipc: fix connection refcount leak erik.hugne
2014-03-06 13:40 ` [PATCH net-next v3 3/6] tipc: avoid to unnecessary process switch under non-block mode erik.hugne
2014-03-06 13:40 ` [PATCH net-next v3 4/6] tipc: drop subscriber connection id invalidation erik.hugne
2014-03-06 13:40 ` [PATCH net-next v3 5/6] tipc: fix memory leak during module removal erik.hugne
2014-03-06 13:40 ` erik.hugne [this message]
2014-03-06 19:47 ` [PATCH net-next v3 0/6] tipc: refcount and memory leak fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394113221-30100-7-git-send-email-erik.hugne@ericsson.com \
--to=erik.hugne@ericsson.com \
--cc=jon.maloy@ericsson.com \
--cc=maloy@donjonn.com \
--cc=netdev@vger.kernel.org \
--cc=richard.alpe@ericsson.com \
--cc=tipc-discussion@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).