From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCHv2 1/3] net: phy: prevent linking breakage Date: Tue, 04 Jun 2013 18:01:07 +0200 Message-ID: <1394174.ONngHnHYKL@wuerfel> References: <1369741403-25315-2-git-send-email-alexandre.belloni@free-electrons.com> <6466898.RnYOe3jpGG@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Florian Fainelli , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, alexandre.belloni@free-electrons.com, kernel@pengutronix.de, shawn.guo@linaro.org, David Miller To: linux-arm-kernel@lists.infradead.org Return-path: Received: from moutng.kundenserver.de ([212.227.17.9]:58943 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754456Ab3FDQBL (ORCPT ); Tue, 4 Jun 2013 12:01:11 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Tuesday 04 June 2013 16:36:50 Florian Fainelli wrote: > It seems to me that what David proposes is to have say an > arch/arm/mach-foo/phy-fixups.c file which is only enabled when > CONFIG_PHYLIB is set (obj-$(CONFIG_PHYLIB) += phy-fixup.o), such that > it does not need to have any conditionnals when calling > phy_register_fixup. This sounds a little unusual, but why not. I don't think it would actually help us, because then we still need to declare a local function that gets called from the board init code. Instead of doing if (IS_ENABLED(CONFIG_PHYLIB)) phy_register_fixup_for_uid(phy_id, foo_phy_fixup); we would then do if (IS_ENABLED(CONFIG_PHYLIB)) foo_phy_fixup_register(); which is not much different at all. Arnd