From: Johannes Berg <johannes@sipsolutions.net>
To: behanw@converseincode.com
Cc: linville@tuxdriver.com, davem@davemloft.net,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
dwmw2@infradead.org, pageexec@freemail.hu,
"Jan-Simon Möller" <dl9pf@gmx.de>,
"Vinícius Tinti" <viniciustinti@gmail.com>,
"Mark Charlebois" <charlebm@gmail.com>
Subject: Re: [PATCH] mac80211: LLVMLinux: Remove VLAIS usage from mac80211
Date: Fri, 07 Mar 2014 08:24:51 +0100 [thread overview]
Message-ID: <1394177091.4653.1.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1394135570-26730-1-git-send-email-behanw@converseincode.com> (sfid-20140306_205408_313446_76872588)
On Thu, 2014-03-06 at 11:52 -0800, behanw@converseincode.com wrote:
> From: Jan-Simon Möller <dl9pf@gmx.de>
>
> Replaced the use of a Variable Length Array In Struct (VLAIS) with a C99
> compliant equivalent.
Fine, but
> + char aead_req_data[sizeof(struct aead_request)
> + + crypto_aead_reqsize(tfm)
> + + CRYPTO_MINALIGN] CRYPTO_MINALIGN_ATTR;
You really should be using kernel coding style, which changes
indentation and has the + on the previous line.
> + struct aead_request *aead_req
> + = (struct aead_request *) aead_req_data;
(void *) is perfectly find and it'll probably fit on one line then.
> + memset(&aead_req_data, 0, (sizeof(struct aead_request)+
> + crypto_aead_reqsize(tfm) + CRYPTO_MINALIGN));
You don't need the size calculation again, you can use
sizeof(aead_req_data)
johannes
next prev parent reply other threads:[~2014-03-07 7:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 19:52 [PATCH] mac80211: LLVMLinux: Remove VLAIS usage from mac80211 behanw
2014-03-07 7:24 ` Johannes Berg [this message]
2014-03-08 1:26 ` [PATCH v2] " behanw
[not found] ` <1394241960-1764-1-git-send-email-behanw-k/hB3zQhLwledRVtV/plodBPR1lH4CV8@public.gmane.org>
2014-03-08 1:56 ` Joe Perches
2014-03-08 2:15 ` Behan Webster
[not found] ` <531A7D4F.7090303-k/hB3zQhLwledRVtV/plodBPR1lH4CV8@public.gmane.org>
2014-03-08 2:27 ` Joe Perches
2014-03-08 20:17 ` Behan Webster
2014-03-08 14:53 ` Stanislaw Gruszka
2014-03-08 21:36 ` Behan Webster
2014-03-08 20:29 ` Sergei Antonov
2014-03-08 20:42 ` Behan Webster
2014-03-08 22:01 ` PaX Team
2014-03-08 23:00 ` Sergei Antonov
[not found] ` <CABikg9x+Z95bHcDc6iu5hBvRNO-ibM8-34_qA+OA_FjB52SPMw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-08 23:41 ` Jan-Simon Möller
2014-03-09 1:58 ` Behan Webster
2014-03-19 3:32 ` [PATCH v3] " behanw
2014-03-19 13:51 ` Johannes Berg
2014-03-19 14:25 ` Behan Webster
[not found] ` <1395237113.4142.5.camel-8Nb76shvtaUJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2014-03-21 6:39 ` [PATCH v4] " behanw-k/hB3zQhLwledRVtV/plodBPR1lH4CV8
2014-03-21 11:59 ` Johannes Berg
2014-03-19 14:09 ` [PATCH v3] " David Laight
2014-03-09 0:01 ` [PATCH v2] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394177091.4653.1.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=behanw@converseincode.com \
--cc=charlebm@gmail.com \
--cc=davem@davemloft.net \
--cc=dl9pf@gmx.de \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=pageexec@freemail.hu \
--cc=torvalds@linux-foundation.org \
--cc=viniciustinti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).