* [PATCH] IB/mlx5_core: remove unreachable function call in module init
@ 2014-03-07 22:48 Kleber Sacilotto de Souza
2014-03-09 6:37 ` Eli Cohen
[not found] ` <1394232505-12142-1-git-send-email-klebers-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
0 siblings, 2 replies; 3+ messages in thread
From: Kleber Sacilotto de Souza @ 2014-03-07 22:48 UTC (permalink / raw)
To: Eli Cohen; +Cc: netdev, linux-rdma, Kleber Sacilotto de Souza
The call to mlx5_health_cleanup() in the module init function can never
be reached. Removing it.
Signed-off-by: Kleber Sacilotto de Souza <klebers@linux.vnet.ibm.com>
---
drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
index 6f7c866..77ac95f 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
@@ -531,7 +531,6 @@ static int __init init(void)
return 0;
- mlx5_health_cleanup();
err_debug:
mlx5_unregister_debugfs();
return err;
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] IB/mlx5_core: remove unreachable function call in module init
2014-03-07 22:48 [PATCH] IB/mlx5_core: remove unreachable function call in module init Kleber Sacilotto de Souza
@ 2014-03-09 6:37 ` Eli Cohen
[not found] ` <1394232505-12142-1-git-send-email-klebers-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
1 sibling, 0 replies; 3+ messages in thread
From: Eli Cohen @ 2014-03-09 6:37 UTC (permalink / raw)
To: Kleber Sacilotto de Souza; +Cc: Eli Cohen, netdev, linux-rdma
Acked-by: Eli Cohen <eli@mellanox.com>
On Fri, Mar 07, 2014 at 07:48:25PM -0300, Kleber Sacilotto de Souza wrote:
> The call to mlx5_health_cleanup() in the module init function can never
> be reached. Removing it.
>
> Signed-off-by: Kleber Sacilotto de Souza <klebers@linux.vnet.ibm.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> index 6f7c866..77ac95f 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> @@ -531,7 +531,6 @@ static int __init init(void)
>
> return 0;
>
> - mlx5_health_cleanup();
> err_debug:
> mlx5_unregister_debugfs();
> return err;
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] IB/mlx5_core: remove unreachable function call in module init
[not found] ` <1394232505-12142-1-git-send-email-klebers-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
@ 2014-03-10 19:23 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2014-03-10 19:23 UTC (permalink / raw)
To: klebers-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8
Cc: eli-VPRAkNaXOzVWk0Htik3J/w, netdev-u79uwXL29TY76Z2rM5mHXA,
linux-rdma-u79uwXL29TY76Z2rM5mHXA
From: Kleber Sacilotto de Souza <klebers-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Date: Fri, 7 Mar 2014 19:48:25 -0300
> The call to mlx5_health_cleanup() in the module init function can never
> be reached. Removing it.
>
> Signed-off-by: Kleber Sacilotto de Souza <klebers-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Applied to net-next, thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-10 19:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-07 22:48 [PATCH] IB/mlx5_core: remove unreachable function call in module init Kleber Sacilotto de Souza
2014-03-09 6:37 ` Eli Cohen
[not found] ` <1394232505-12142-1-git-send-email-klebers-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2014-03-10 19:23 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).