From: Shahed Shaikh <shahed.shaikh@qlogic.com>
To: <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <Dept-HSGLinuxNICDev@qlogic.com>,
Shahed Shaikh <shahed.shaikh@qlogic.com>
Subject: [PATCH net-next 1/5] vxlan: Make VXLAN default UDP port number available for others
Date: Mon, 10 Mar 2014 12:48:58 -0400 [thread overview]
Message-ID: <1394470142-13992-2-git-send-email-shahed.shaikh@qlogic.com> (raw)
In-Reply-To: <1394470142-13992-1-git-send-email-shahed.shaikh@qlogic.com>
From: Shahed Shaikh <shahed.shaikh@qlogic.com>
Although vxlan module has capability to notify udp ports to
other interested net devices using .ndo_add_rx_vxlan_port and
.ndo_del_rx_vxlan_port, there could be some devices which support
vxlan offload but not interested in updating udp port numbers.
This may be because some hardware do not support programming multiple
udp ports and their drivers may decide to program only default udp port
into adapter. So that adapter, at least, can do offloading for
default udp port number.
Signed-off-by: Shahed Shaikh <shahed.shaikh@qlogic.com>
---
drivers/net/vxlan.c | 6 +-----
include/net/vxlan.h | 6 ++++++
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index eb59b14..ace758f 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -71,11 +71,7 @@ struct vxlanhdr {
__be32 vx_vni;
};
-/* UDP port for VXLAN traffic.
- * The IANA assigned port is 4789, but the Linux default is 8472
- * for compatibility with early adopters.
- */
-static unsigned short vxlan_port __read_mostly = 8472;
+static unsigned short vxlan_port __read_mostly = VXLAN_DEFAULT_PORT;
module_param_named(udp_port, vxlan_port, ushort, 0444);
MODULE_PARM_DESC(udp_port, "Destination UDP port");
diff --git a/include/net/vxlan.h b/include/net/vxlan.h
index 5deef1a..4c16629 100644
--- a/include/net/vxlan.h
+++ b/include/net/vxlan.h
@@ -8,6 +8,12 @@
#define VNI_HASH_BITS 10
#define VNI_HASH_SIZE (1<<VNI_HASH_BITS)
+/* UDP port for VXLAN traffic.
+ * The IANA assigned port is 4789, but the Linux default is 8472
+ * for compatibility with early adopters.
+ */
+#define VXLAN_DEFAULT_PORT 8472
+
struct vxlan_sock;
typedef void (vxlan_rcv_t)(struct vxlan_sock *vh, struct sk_buff *skb, __be32 key);
--
1.8.3.1
next prev parent reply other threads:[~2014-03-10 17:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 16:48 [PATCH net-next 0/5] VXLAN offload support Shahed Shaikh
2014-03-10 16:48 ` Shahed Shaikh [this message]
2014-03-10 19:43 ` [PATCH net-next 1/5] vxlan: Make VXLAN default UDP port number available for others Stephen Hemminger
2014-03-11 5:37 ` Shahed Shaikh
2014-03-10 19:57 ` Or Gerlitz
2014-03-11 5:41 ` Shahed Shaikh
2014-03-11 6:42 ` Or Gerlitz
2014-03-11 7:22 ` Shahed Shaikh
2014-03-11 15:28 ` Stephen Hemminger
2014-03-12 9:44 ` Shahed Shaikh
2014-03-11 17:28 ` Joseph Gasparakis
2014-03-12 10:20 ` Shahed Shaikh
2014-03-10 16:48 ` [PATCH net-next 2/5] qlcnic: Get NIC capabilities using mailbox poll mode Shahed Shaikh
2014-03-10 16:49 ` [PATCH net-next 3/5] qlcnic: Add VXLAN Tx offload support Shahed Shaikh
2014-03-10 16:49 ` [PATCH net-next 4/5] qlcnic: Add VXLAN Rx offload support for 84xx Shahed Shaikh
2014-03-10 16:49 ` [PATCH net-next 5/5] qlcnic: Update version to 5.3.57 Shahed Shaikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394470142-13992-2-git-send-email-shahed.shaikh@qlogic.com \
--to=shahed.shaikh@qlogic.com \
--cc=Dept-HSGLinuxNICDev@qlogic.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).