netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Tom Herbert <therbert@google.com>,
	netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 02/13] net: igb calls skb_set_hash
Date: Tue, 11 Mar 2014 22:53:27 -0700	[thread overview]
Message-ID: <1394603618-1044-3-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1394603618-1044-1-git-send-email-jeffrey.t.kirsher@intel.com>

From: Tom Herbert <therbert@google.com>

Drivers should call skb_set_hash to set the hash and its type
in an skbuff.

Signed-off-by: Tom Herbert <therbert@google.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/igb/igb_main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index 3384156..a96beb6 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -6620,7 +6620,9 @@ static inline void igb_rx_hash(struct igb_ring *ring,
 			       struct sk_buff *skb)
 {
 	if (ring->netdev->features & NETIF_F_RXHASH)
-		skb->rxhash = le32_to_cpu(rx_desc->wb.lower.hi_dword.rss);
+		skb_set_hash(skb,
+			     le32_to_cpu(rx_desc->wb.lower.hi_dword.rss),
+			     PKT_HASH_TYPE_L3);
 }
 
 /**
-- 
1.8.3.1

  parent reply	other threads:[~2014-03-12  5:53 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-12  5:53 [net-next 00/13][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2014-03-12  5:53 ` [net-next 01/13] net: e1000e calls skb_set_hash Jeff Kirsher
2014-03-12  5:53 ` Jeff Kirsher [this message]
2014-03-12  5:53 ` [net-next 03/13] igb: Fix for devices using ethtool for EEE settings Jeff Kirsher
2014-03-12  5:53 ` [net-next 04/13] igb: Add debugfs skeleton Jeff Kirsher
2014-03-12  5:53 ` [net-next 05/13] igb: Add support for debugfs Jeff Kirsher
2014-03-12 15:57   ` Or Gerlitz
2014-03-12 16:35     ` Wyborny, Carolyn
2014-03-12 19:46       ` David Miller
2014-03-12 20:13         ` Wyborny, Carolyn
2014-03-12 20:24           ` David Miller
2014-03-12 20:31             ` Wyborny, Carolyn
2014-03-12  5:53 ` [net-next 06/13] igb: Add debugfs command/register read and write functionality Jeff Kirsher
2014-03-12  5:53 ` [net-next 07/13] net: ixgbe calls skb_set_hash Jeff Kirsher
2014-03-12  5:53 ` [net-next 08/13] ixgbe: Fix format string in ixgbe_fcoe.c Jeff Kirsher
2014-03-12  5:53 ` [net-next 09/13] ixgbe: move setting rx_pb_size into get_invariants Jeff Kirsher
2014-03-12  5:53 ` [net-next 10/13] ixgbe: add Linux NICS mailing list to contact info Jeff Kirsher
2014-03-12  5:53 ` [net-next 11/13] ixgbe: fixup header for ixgbe_set_rxpba_82598 Jeff Kirsher
2014-03-12  5:53 ` [net-next 12/13] ixgbe: fix some multiline hw_dbg prints Jeff Kirsher
2014-03-12 14:51   ` Sergei Shtylyov
2014-03-12 18:31     ` Keller, Jacob E
2014-03-12 20:11       ` Sergei Shtylyov
2014-03-12 20:24         ` Sergei Shtylyov
2014-03-12 20:21           ` Keller, Jacob E
2014-03-12  5:53 ` [net-next 13/13] ixgbevf: delete unneeded call to pci_set_power_state Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394603618-1044-3-git-send-email-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=davem@davemloft.net \
    --cc=gospo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=sassmann@redhat.com \
    --cc=therbert@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).