netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hayes Wang <hayeswang@realtek.com>
To: <netdev@vger.kernel.org>
Cc: <nic_swsd@realtek.com>, <linux-kernel@vger.kernel.org>,
	<linux-usb@vger.kernel.org>, Hayes Wang <hayeswang@realtek.com>
Subject: [PATCH net 2/3] r8152: fix remote wakeup
Date: Thu, 23 Jul 2015 15:09:06 +0800	[thread overview]
Message-ID: <1394712342-15778-150-Taiwan-albertk@realtek.com> (raw)
In-Reply-To: <1394712342-15778-148-Taiwan-albertk@realtek.com>

Set needs_remote_wakeup only when the device supports it.

Signed-off-by: Hayes Wang <hayeswang@realtek.com>
---
 drivers/net/usb/r8152.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index e3a0110..eff1f25 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -4059,7 +4059,8 @@ static int rtl8152_probe(struct usb_interface *intf,
 		break;
 	}
 
-	intf->needs_remote_wakeup = 1;
+	if (udev->actconfig->desc.bmAttributes & USB_CONFIG_ATT_WAKEUP)
+		intf->needs_remote_wakeup = 1;
 
 	tp->rtl_ops.init(tp);
 	set_ethernet_addr(tp);
-- 
2.4.2

  parent reply	other threads:[~2015-07-23  7:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-23  7:09 [PATCH net 0/3] r8152: issues fix Hayes Wang
2015-07-23  7:09 ` [PATCH net 1/3] r8152: fix the issue about U1/U2 Hayes Wang
2015-07-23  7:09 ` Hayes Wang [this message]
     [not found]   ` <1394712342-15778-150-Taiwan-albertk-Rasf1IRRPZFBDgjK7y7TUQ@public.gmane.org>
2015-07-23  8:30     ` [PATCH net 2/3] r8152: fix remote wakeup Oliver Neukum
     [not found]       ` <1437640258.4377.6.camel-IBi9RG/b67k@public.gmane.org>
2015-07-23  9:55         ` Hayes Wang
2015-07-23 10:27           ` Oliver Neukum
     [not found]             ` <1437647246.4377.33.camel-IBi9RG/b67k@public.gmane.org>
2015-07-23 11:30               ` Hayes Wang
2015-07-23  7:09 ` [PATCH net 3/3] r8152: don't enable napi before rx ready Hayes Wang
2015-07-24  5:54 ` [PATCH net v2 0/3] r8152: issues fix Hayes Wang
2015-07-24  5:54   ` [PATCH net v2 1/3] r8152: fix the issue about U1/U2 Hayes Wang
2015-07-24  5:54   ` [PATCH net v2 2/3] r8152: fix wakeup settings Hayes Wang
2015-07-24  5:54   ` [PATCH net v2 3/3] r8152: don't enable napi before rx ready Hayes Wang
2015-07-27  7:56   ` [PATCH net v2 0/3] r8152: issues fix David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394712342-15778-150-Taiwan-albertk@realtek.com \
    --to=hayeswang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).