Netdev List
 help / color / mirror / Atom feed
From: Hayes Wang <hayeswang@realtek.com>
To: <netdev@vger.kernel.org>
Cc: <nic_swsd@realtek.com>, <linux-kernel@vger.kernel.org>,
	<linux-usb@vger.kernel.org>, Hayes Wang <hayeswang@realtek.com>
Subject: [PATCH net-next 09/11] r8152: check if disabling ALDPS is finished
Date: Fri, 9 Jun 2017 17:11:46 +0800	[thread overview]
Message-ID: <1394712342-15778-269-Taiwan-albertk@realtek.com> (raw)
In-Reply-To: <1394712342-15778-260-Taiwan-albertk@realtek.com>

Use PLA 0xe000 bit 8 to check if disabling ALDPS is finished.

Signed-off-by: Hayes Wang <hayeswang@realtek.com>
---
 drivers/net/usb/r8152.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index f43b7a8..204f4b2 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -2836,9 +2836,15 @@ static void r8153_aldps_en(struct r8152 *tp, bool enable)
 		data |= EN_ALDPS;
 		ocp_reg_write(tp, OCP_POWER_CFG, data);
 	} else {
+		int i;
+
 		data &= ~EN_ALDPS;
 		ocp_reg_write(tp, OCP_POWER_CFG, data);
-		msleep(20);
+		for (i = 0; i < 20; i++) {
+			usleep_range(1000, 2000);
+			if (ocp_read_word(tp, MCU_TYPE_PLA, 0xe000) & 0x0100)
+				break;
+		}
 	}
 }
 
-- 
2.7.4

  parent reply	other threads:[~2017-06-09  9:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-09  9:11 [PATCH net-next 00/11] r8152: minor adjustment Hayes Wang
2017-06-09  9:11 ` [PATCH net-next 01/11] r8152: add r8153_phy_status function Hayes Wang
2017-06-09  9:11 ` [PATCH net-next 02/11] r8152: adjust lpm settings for RTL8153 Hayes Wang
2017-06-09  9:11 ` [PATCH net-next 03/11] r8152: adjust the settings about MAC clock speed down " Hayes Wang
2017-06-09  9:11 ` [PATCH net-next 04/11] r8152: move the setting of rx aggregation Hayes Wang
2017-06-09  9:11 ` [PATCH net-next 05/11] r8152: adjust rtl8153_runtime_enable function Hayes Wang
2017-06-09  9:11 ` [PATCH net-next 06/11] r8152: adjust U2P3 for RTL8153 Hayes Wang
2017-06-09  9:11 ` [PATCH net-next 07/11] r8152: move the default coalesce setting " Hayes Wang
2017-06-09  9:11 ` [PATCH net-next 08/11] r8152: move the initialization to reset_resume function Hayes Wang
2017-06-09  9:11 ` Hayes Wang [this message]
2017-06-09  9:11 ` [PATCH net-next 10/11] r8152: avoid rx queue more than 1000 packets Hayes Wang
2017-06-09  9:11 ` [PATCH net-next 11/11] r8152: replace napi_complete with napi_complete_done Hayes Wang
2017-06-09 19:38 ` [PATCH net-next 00/11] r8152: minor adjustment David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394712342-15778-269-Taiwan-albertk@realtek.com \
    --to=hayeswang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox