From: Joe Perches <joe@perches.com>
To: Byungho An <bh74.an@samsung.com>
Cc: netdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
davem@davemloft.net, ilho215.lee@samsung.com,
siva.kallam@samsung.com, vipul.pandya@samsung.com,
ks.giri@samsung.com
Subject: Re: [PATCH V2 RE-SEND 1/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver
Date: Thu, 13 Mar 2014 06:02:23 -0700 [thread overview]
Message-ID: <1394715743.3915.79.camel@joe-AO722> (raw)
In-Reply-To: <1394715189.3915.76.camel@joe-AO722>
On Thu, 2014-03-13 at 05:53 -0700, Joe Perches wrote:
> Maybe this was supposed to be something like
>
> ns = p->tstamp_lo
> ns |= ((u64)tstamp_hi) << 32;
>
> If not, maybe it warrants a comment around
> here or on the descriptor definition
[]
> > +struct sxgbe_rx_ctxt_desc {
> > + u32 tstamp_lo:32;
> > + u32 tstamp_hi:32;
or maybe these would be better renamed like:
u32 tstamp_nsecs;
u32 tstamp_secs;
btw2: I still think using
u32 foo:32;
is asking for gcc to generate bad code.
next prev parent reply other threads:[~2014-03-13 13:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 6:55 [PATCH V2 RE-SEND 1/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver Byungho An
2014-03-13 12:53 ` Joe Perches
2014-03-13 13:02 ` Joe Perches [this message]
2014-03-14 0:44 ` Francois Romieu
2014-03-16 0:09 ` Andrew.an
2014-03-16 23:11 ` Francois Romieu
2014-03-17 3:53 ` Byungho An
2014-03-17 16:58 ` Stephen Hemminger
2014-03-17 17:38 ` Byungho An
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394715743.3915.79.camel@joe-AO722 \
--to=joe@perches.com \
--cc=bh74.an@samsung.com \
--cc=davem@davemloft.net \
--cc=ilho215.lee@samsung.com \
--cc=ks.giri@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=siva.kallam@samsung.com \
--cc=vipul.pandya@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox