netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Kevin Hao <haokexin@gmail.com>
Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] e1000e: fix the build error when PM is disabled
Date: Fri, 14 Mar 2014 01:55:43 -0700	[thread overview]
Message-ID: <1394787343.2167.48.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1394780233-8066-1-git-send-email-haokexin@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 992 bytes --]

On Fri, 2014-03-14 at 14:57 +0800, Kevin Hao wrote:
> The commit 2800209994f8 (e1000e: Refactor PM flows) changed the
> SET_SYSTEM_SLEEP_PM_OPS to open-coded assignment, but forgot to
> protect them with CONFIG_PM_SLEEP. Then cause the following build
> error when PM is disabled:
> drivers/net/ethernet/intel/e1000e/netdev.c:7079:13:
> error: 'e1000e_pm_suspend' undeclared here (not in a function)
>   .suspend = e1000e_pm_suspend,
>              ^
> drivers/net/ethernet/intel/e1000e/netdev.c:7080:13:
> error: 'e1000e_pm_resume' undeclared here (not in a function)
>   .resume  = e1000e_pm_resume,
>              ^
> drivers/net/ethernet/intel/e1000e/netdev.c:7082:11:
> error: 'e1000e_pm_thaw' undeclared here (not in a function)
>   .thaw  = e1000e_pm_thaw,
>            ^
> 
> Signed-off-by: Kevin Hao <haokexin@gmail.com>
> ---
>  drivers/net/ethernet/intel/e1000e/netdev.c | 2 ++
>  1 file changed, 2 insertions(+)

Thanks Kevin, I will add this to my queue.

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 370 bytes --]

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech

[-- Attachment #3: Type: text/plain, Size: 257 bytes --]

_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired

      reply	other threads:[~2014-03-14  8:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-14  6:57 [PATCH net-next] e1000e: fix the build error when PM is disabled Kevin Hao
2014-03-14  8:55 ` Jeff Kirsher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394787343.2167.48.camel@jtkirshe-mobl \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=haokexin@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).