Re: [PATCH net-next 02/10] e1000e: add timeout for TX HW time stamping work

[Joe Perches <joe@perches.com>]

On Fri, 2014-03-14 at 18:34 +0100, Jakub Kicinski wrote:
> Hardware may fail to report time stamp e.g.:
>  - when hardware time stamping is not enabled
>  - when time stamp is requested shortly after ifup

trivia:

> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
[]
> @@ -1155,6 +1155,12 @@ static void e1000e_tx_hwtstamp_work(struct work_struct *work)
>  		skb_tstamp_tx(adapter->tx_hwtstamp_skb, &shhwtstamps);
>  		dev_kfree_skb_any(adapter->tx_hwtstamp_skb);
>  		adapter->tx_hwtstamp_skb = NULL;
> +	} else if (time_after(jiffies, adapter->tx_hwtstamp_start
> +			      + adapter->tx_timeout_factor * HZ)) {
> +		dev_kfree_skb_any(adapter->tx_hwtstamp_skb);
> +		adapter->tx_hwtstamp_skb = NULL;
> +		adapter->tx_hwtstamp_timeouts++;
> +		e_warn("clearing Tx timestamp hang");

Missing \n termination




------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired