From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Jakub Kicinski <kubakici@wp.pl>
Cc: netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net
Subject: Re: [PATCH net-next 09/10] i40e: never generate both software and hardware timestamps
Date: Fri, 14 Mar 2014 16:18:48 -0700 [thread overview]
Message-ID: <1394839128.2167.95.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1394818481-7652-10-git-send-email-kubakici@wp.pl>
[-- Attachment #1: Type: text/plain, Size: 581 bytes --]
On Fri, 2014-03-14 at 18:34 +0100, Jakub Kicinski wrote:
> skb_tx_timestamp() does not report software time stamp
> if SKBTX_IN_PROGRESS is set. According to timestamping.txt
> software time stamps are a fallback and should not be
> generated if hardware time stamp is provided.
>
> Move call to skb_tx_timestamp() after setting
> SKBTX_IN_PROGRESS.
>
> Signed-off-by: Jakub Kicinski <kubakici@wp.pl>
> ---
> drivers/net/ethernet/intel/i40e/i40e_txrx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks Jakub, I will add this patch to my queue.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-03-14 23:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 17:34 [PATCH net-next 00/10] Small fixes for Tx time stamping in Intel drivers Jakub Kicinski
2014-03-14 17:34 ` [PATCH net-next 01/10] doc: update driver TX algorithm in timestamping.txt Jakub Kicinski
2014-03-14 19:12 ` Sergei Shtylyov
2014-03-14 17:34 ` [PATCH net-next 02/10] e1000e: add timeout for TX HW time stamping work Jakub Kicinski
2014-03-14 17:48 ` Joe Perches
2014-03-14 18:02 ` Jakub Kiciński
2014-03-14 18:44 ` Joe Perches
2014-03-14 19:14 ` Joe Perches
2014-03-14 19:16 ` Jakub Kiciński
2014-03-14 23:20 ` Jeff Kirsher
2014-03-14 17:34 ` [PATCH net-next 03/10] e1000e: remove redundant if clause from PTP work Jakub Kicinski
2014-03-14 23:17 ` Jeff Kirsher
2014-03-14 17:34 ` [PATCH net-next 04/10] ixgbe: " Jakub Kicinski
2014-03-14 23:17 ` Jeff Kirsher
2014-03-14 17:34 ` [PATCH net-next 05/10] ixgbe: never generate both software and hardware timestamps Jakub Kicinski
2014-03-14 23:17 ` Jeff Kirsher
2014-03-14 17:34 ` [PATCH net-next 06/10] ixgbe: fix race conditions on queuing skb for HW time stamp Jakub Kicinski
2014-03-14 23:18 ` Jeff Kirsher
2014-03-14 17:34 ` [PATCH net-next 07/10] igb: never generate both software and hardware timestamps Jakub Kicinski
2014-03-14 23:18 ` Jeff Kirsher
2014-03-14 17:34 ` [PATCH net-next 08/10] igb: fix race conditions on queuing skb for HW time stamp Jakub Kicinski
2014-03-14 23:18 ` Jeff Kirsher
2014-03-14 17:34 ` [PATCH net-next 09/10] i40e: never generate both software and hardware timestamps Jakub Kicinski
2014-03-14 23:18 ` Jeff Kirsher [this message]
2014-03-14 17:34 ` [PATCH net-next 10/10] i40e: fix race conditions on queuing skb for HW time stamp Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394839128.2167.95.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=kubakici@wp.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).