From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Shannon Nelson <shannon.nelson@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
Catherine Sullivan <catherine.sullivan@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next v2 02/14] i40e: delete netdev after deleting napi and vectors
Date: Fri, 14 Mar 2014 16:34:23 -0700 [thread overview]
Message-ID: <1394840075-6851-3-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1394840075-6851-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Shannon Nelson <shannon.nelson@intel.com>
We've been deleting the netdev before getting around to deleting the napi
structs. Unfortunately, we then didn't delete the napi structs because we
have a check for netdev, thus we were leaving garbage around in the system.
Change-ID: Ife540176f6c9f801147495b3f2d2ac2e61ddcc58
Signed-off-by: Shannon Nelson <shannon.nelson@intel.com>
Signed-off-by: Catherine Sullivan <catherine.sullivan@intel.com>
Tested-by: Kavindya Deegala <kavindya.s.deegala@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 43d391b..a3f122e 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -6806,8 +6806,6 @@ int i40e_vsi_release(struct i40e_vsi *vsi)
if (vsi->netdev) {
/* results in a call to i40e_close() */
unregister_netdev(vsi->netdev);
- free_netdev(vsi->netdev);
- vsi->netdev = NULL;
}
} else {
if (!test_and_set_bit(__I40E_DOWN, &vsi->state))
@@ -6826,6 +6824,10 @@ int i40e_vsi_release(struct i40e_vsi *vsi)
i40e_vsi_delete(vsi);
i40e_vsi_free_q_vectors(vsi);
+ if (vsi->netdev) {
+ free_netdev(vsi->netdev);
+ vsi->netdev = NULL;
+ }
i40e_vsi_clear_rings(vsi);
i40e_vsi_clear(vsi);
--
1.8.3.1
next prev parent reply other threads:[~2014-03-14 23:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 23:34 [net-next v2 00/14][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2014-03-14 23:34 ` [net-next v2 01/14] igb: Fix code comment Jeff Kirsher
2014-03-14 23:34 ` Jeff Kirsher [this message]
2014-03-14 23:34 ` [net-next v2 03/14] i40e: Fix a bug in the update logic for FDIR SB filter Jeff Kirsher
2014-03-14 23:34 ` [net-next v2 04/14] i40e/i40evf: Some flow director HW definition fixes Jeff Kirsher
2014-03-14 23:34 ` [net-next v2 05/14] i40e: make string references to q be queue Jeff Kirsher
2014-03-14 23:34 ` [net-next v2 06/14] i40e: cleanup strings Jeff Kirsher
2014-03-14 23:34 ` [net-next v2 07/14] i40e: simplified init string Jeff Kirsher
2014-03-14 23:34 ` [net-next v2 08/14] i40e: Fix function comments Jeff Kirsher
2014-03-14 23:34 ` [net-next v2 09/14] i40e: Define a new state variable to keep track of feature auto disable Jeff Kirsher
2014-03-14 23:34 ` [net-next v2 10/14] i40e: Add code to handle FD table full condition Jeff Kirsher
2014-03-14 23:34 ` [net-next v2 11/14] i40e: Bug fix for FDIR replay logic Jeff Kirsher
2014-03-14 23:34 ` [net-next v2 12/14] i40e: Let MDD events be handled by MDD handler Jeff Kirsher
2014-03-14 23:34 ` [net-next v2 13/14] i40e/i40evf: Use correct number of VF vectors Jeff Kirsher
2014-03-14 23:34 ` [net-next v2 14/14] i40e/i40evf: Use dma_set_mask_and_coherent Jeff Kirsher
2014-03-15 2:19 ` [net-next v2 00/14][pull request] Intel Wired LAN Driver Updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394840075-6851-3-git-send-email-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=catherine.sullivan@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
--cc=shannon.nelson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).