From: Ben Hutchings <ben@decadent.org.uk>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Tom Gundersen <teg@jklm.no>,
Johannes berg <johannes@sipsolutions.net>,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 1/4] net: add name_assign_type netdev attribute
Date: Sun, 16 Mar 2014 19:17:09 +0000 [thread overview]
Message-ID: <1394997429.15764.116.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <1394990490-1076-2-git-send-email-dh.herrmann@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
On Sun, 2014-03-16 at 18:21 +0100, David Herrmann wrote:
[...]
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -74,6 +74,11 @@ void netdev_set_default_ethtool_ops(struct net_device *dev,
> #define NET_RX_SUCCESS 0 /* keep 'em coming, baby */
> #define NET_RX_DROP 1 /* packet dropped */
>
> +/* interface name assignment types */
> +#define NET_NAME_ENUM 0 /* enumerated by kernel (default) */
> +#define NET_NAME_USER 1 /* provided by user-space */
> +#define NET_NAME_RENAMED 2 /* renamed by user-space */
[...]
I think these definitions should be put in a UAPI header. Even if the
names don't end up being used by userland, that would make it clear that
the numbers are a stable ABI.
Ben.
--
Ben Hutchings
Computers are not intelligent. They only think they are.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
next prev parent reply other threads:[~2014-03-16 19:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-16 17:21 [PATCH v2 0/4] Provide netdev naming-policy via sysfs David Herrmann
2014-03-16 17:21 ` [PATCH v2 1/4] net: add name_assign_type netdev attribute David Herrmann
2014-03-16 19:17 ` Ben Hutchings [this message]
2014-03-16 21:53 ` David Herrmann
2014-03-17 17:03 ` [PATCH v3 " David Herrmann
2014-03-17 17:12 ` David Laight
2014-03-17 18:01 ` [PATCH v4 " David Herrmann
[not found] ` <1395079295-1325-1-git-send-email-dh.herrmann-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-03-17 19:28 ` David Miller
[not found] ` <1394990490-1076-1-git-send-email-dh.herrmann-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-03-16 17:21 ` [PATCH v2 2/4] mac80211: set NET_NAME_USER for user-space created ifs David Herrmann
2014-03-16 17:21 ` [PATCH v2 3/4] ath6kl: set NET_NAME_USER for P2P ifs David Herrmann
2014-03-16 17:21 ` [PATCH v2 4/4] brcmfmac: " David Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394997429.15764.116.camel@deadeye.wl.decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=dh.herrmann@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=teg@jklm.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox