Re: [PATCH] net : Remove unnecessary assignments

[Joe Perches <joe@perches.com>]

On Tue, 2014-03-18 at 16:22 +0000, David Laight wrote:
> From: Behalf Of Balakumaran Kannan
> > Remove unnecessary assignments
> > 
> > Signed-off-by: Balakumaran Kannan <kumaran.4353@gmail.com>
> > ---
> > Some unnecessary assignments has been removed from devinet_ioctl function.
> > The 'ret' variable is set in multiple places, but used only based on if
> > conditions. So keeping the assignment inside if will be a better.
> ...
> 
> These all seem to be this transform:
> > -	ret = -ENODEV;
> >  	dev = __dev_get_by_name(net, ifr.ifr_name);
> > -	if (!dev)
> > +	if (!dev) {
> > +		ret = -ENODEV;
> >  		goto done;
> > +	}
> 
> I bet that if you look at the generated code you'll find
> that the compiler generates the same code for both forms
> and is likely to generate the equivalent of:
> 	dev = __dev_get_by_name(net, ifr.ifr_name);
> 	ret = -ENODEV;
> 	if (!dev)
> 		goto done;
> 
> So this is just a matter of style.

Yabut it's Linus' preferred style.
http://lkml.org/lkml/2008/12/16/383

(but not mine, I prefer what's done by the patch)