From: Joe Perches <joe@perches.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Jean Sacren <sakiwit@gmail.com>,
Alexander Smirnov <alex.bluesman.smirnov@gmail.com>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
linux-zigbee-devel@lists.sourceforge.net, netdev@vger.kernel.org,
Phoebe Buckheister <phoebe.buckheister@itwm.fraunhofer.de>
Subject: Re: [PATCH net-next] ieee802154: fix variable declaration and initializer
Date: Tue, 18 Mar 2014 20:42:37 -0700 [thread overview]
Message-ID: <1395200557.8649.20.camel@joe-AO722> (raw)
In-Reply-To: <1395199941.9114.47.camel@edumazet-glaptop2.roam.corp.google.com>
On Tue, 2014-03-18 at 20:32 -0700, Eric Dumazet wrote:
> On Tue, 2014-03-18 at 21:19 -0600, Jean Sacren wrote:
>
> > 2) Fix the initializer by deleting the double logical negation
> > operators as they don't serve any purpose.
> >
> ...
> >
> > static int phy_set_lbt(struct wpan_phy *phy, struct genl_info *info)
> > {
> > - u8 on = !!nla_get_u8(info->attrs[IEEE802154_ATTR_LBT_ENABLED]);
>
> You do realize !!(a) is not equivalent to (a) ?
It is when the type it's assigned to also changes
from u8 to bool.
I don't think it's a great style though.
I think the !! doesn't hurt here.
I'd've preferred it to be
bool on = nla_get_u8(...)
rather than separating the declaration from the assignment
by a few lines of code.
next prev parent reply other threads:[~2014-03-19 3:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 3:19 [PATCH net-next] ieee802154: fix variable declaration and initializer Jean Sacren
[not found] ` <1395199198-14310-1-git-send-email-sakiwit-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-03-19 3:32 ` Eric Dumazet
2014-03-19 3:42 ` Joe Perches [this message]
2014-03-19 4:35 ` Eric Dumazet
2014-03-19 4:56 ` Jean Sacren
[not found] ` <20140319045634.GB1448-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-19 5:11 ` Joe Perches
2014-03-19 5:13 ` Eric Dumazet
2014-03-19 5:11 ` Joe Perches
2014-03-19 4:31 ` Jean Sacren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395200557.8649.20.camel@joe-AO722 \
--to=joe@perches.com \
--cc=alex.bluesman.smirnov@gmail.com \
--cc=dbaryshkov@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-zigbee-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=phoebe.buckheister@itwm.fraunhofer.de \
--cc=sakiwit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).