From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Jakub Kicinski <kubakici@wp.pl>
Cc: netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net
Subject: Re: [PATCH net-next] ixgbe: stop PTP before suspending
Date: Thu, 20 Mar 2014 18:36:37 -0700 [thread overview]
Message-ID: <1395365797.2050.48.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1395342872-13496-1-git-send-email-kubakici@wp.pl>
[-- Attachment #1: Type: text/plain, Size: 771 bytes --]
On Thu, 2014-03-20 at 20:14 +0100, Jakub Kicinski wrote:
> Resume path calls .open but suspend path cannot call .stop because
> fdirs should not be freed and control over hardware should not be
> released until WoL is configured. To avoid having to duplicate all
> changes made in .stop on suspend path split out part of .stop that
> is relevant during suspend and call it from .stop and during suspend.
>
> This fixes ixgbe_ptp_stop() not being called on suspend and helps
> to avoid similar bugs in the future.
>
> Signed-off-by: Jakub Kicinski <kubakici@wp.pl>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 27
> ++++++++++++++-------------
> 1 file changed, 14 insertions(+), 13 deletions(-)
Thanks Jakub, I will add this to my queue.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-03-21 1:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 19:14 [PATCH net-next] ixgbe: stop PTP before suspending Jakub Kicinski
2014-03-21 1:36 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395365797.2050.48.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=kubakici@wp.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).