From: Andrey Vagin <avagin@openvz.org>
To: linux-kernel@vger.kernel.org
Cc: criu@openvz.org, netdev@vger.kernel.org,
Andrey Vagin <avagin@openvz.org>,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
Eric Dumazet <edumazet@google.com>,
Pavel Emelyanov <xemul@parallels.com>,
Cyrill Gorcunov <gorcunov@openvz.org>
Subject: [PATCH 3/3] tcp: add ability to restore a fin packet
Date: Fri, 21 Mar 2014 17:33:01 +0400 [thread overview]
Message-ID: <1395408781-8145-4-git-send-email-avagin@openvz.org> (raw)
In-Reply-To: <1395408781-8145-1-git-send-email-avagin@openvz.org>
It's required for restoring sockets in closing states:
TCP_FIN_WAIT{1,2}, TCP_WAIT_STOP, TCP_CLOSING, TCP_LAST_ACK.
A fin packet is restored by sending a control message (ancillary data).
In which queue a packet is restored depends on a value of
tp->repair_queue.
This interface is choosen, because we are goint to use sendmsg for
restoring sockets in TCP_SYN_RECV states. Requests in the TCP_SYN_RECV
state will be restored by sending messages in a proper listen socket. A
message will contain address and a control messages with sequence
numbers.
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Cc: James Morris <jmorris@namei.org>
Cc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
Cc: Patrick McHardy <kaber@trash.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Pavel Emelyanov <xemul@parallels.com>
Cc: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Andrey Vagin <avagin@openvz.org>
---
include/net/tcp.h | 1 +
include/uapi/linux/tcp.h | 3 +++
net/ipv4/tcp.c | 40 ++++++++++++++++++++++++++++++++++++++++
net/ipv4/tcp_input.c | 2 +-
4 files changed, 45 insertions(+), 1 deletion(-)
diff --git a/include/net/tcp.h b/include/net/tcp.h
index 8c4dd63..4b4d9e8 100644
--- a/include/net/tcp.h
+++ b/include/net/tcp.h
@@ -561,6 +561,7 @@ void tcp_cwnd_application_limited(struct sock *sk);
void tcp_resume_early_retransmit(struct sock *sk);
void tcp_rearm_rto(struct sock *sk);
void tcp_reset(struct sock *sk);
+void tcp_fin(struct sock *sk);
/* tcp_timer.c */
void tcp_init_xmit_timers(struct sock *);
diff --git a/include/uapi/linux/tcp.h b/include/uapi/linux/tcp.h
index 377f1e5..2cc6876 100644
--- a/include/uapi/linux/tcp.h
+++ b/include/uapi/linux/tcp.h
@@ -199,4 +199,7 @@ struct tcp_md5sig {
__u8 tcpm_key[TCP_MD5SIG_MAXKEYLEN]; /* key (binary) */
};
+/* Conntroll message types to repair tcp connections */
+#define TCP_REPAIR_SEND_FIN 1
+
#endif /* _UAPI_LINUX_TCP_H */
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 4cd0e87..7f5a15c 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -1070,6 +1070,34 @@ static int tcp_sendmsg_fastopen(struct sock *sk, struct msghdr *msg,
return err;
}
+static int tcp_repair_cmsg(struct sock *sk, struct msghdr *msg)
+{
+ struct tcp_sock *tp = tcp_sk(sk);
+ struct cmsghdr *cmsg;
+
+ for (cmsg = CMSG_FIRSTHDR(msg); cmsg; cmsg = CMSG_NXTHDR(msg, cmsg)) {
+ if (!CMSG_OK(msg, cmsg))
+ return -EINVAL;
+ if (cmsg->cmsg_level != SOL_TCP)
+ continue;
+
+ switch (cmsg->cmsg_type) {
+ case TCP_REPAIR_SEND_FIN:
+ if (tp->repair_queue == TCP_RECV_QUEUE)
+ tcp_fin(sk);
+ else if (tp->repair_queue == TCP_SEND_QUEUE)
+ tcp_shutdown(sk, SEND_SHUTDOWN);
+ else
+ return -EINVAL;
+ break;
+ default:
+ return -EINVAL;
+ }
+ }
+
+ return 0;
+}
+
int tcp_sendmsg(struct kiocb *iocb, struct sock *sk, struct msghdr *msg,
size_t size)
{
@@ -1090,6 +1118,18 @@ int tcp_sendmsg(struct kiocb *iocb, struct sock *sk, struct msghdr *msg,
if (tp->repair_queue == TCP_NO_QUEUE)
goto out_err;
+ if (msg->msg_controllen) {
+ if (size != 0)
+ return -EINVAL;
+
+ err = tcp_repair_cmsg(sk, msg);
+ if (err < 0)
+ goto out_err;
+
+ goto out;
+ }
+
+ err = -EINVAL;
if (sk->sk_state != TCP_ESTABLISHED)
goto out_err;
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index eeaac39..352480c 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -3820,7 +3820,7 @@ void tcp_reset(struct sock *sk)
*
* If we are in FINWAIT-2, a received FIN moves us to TIME-WAIT.
*/
-static void tcp_fin(struct sock *sk)
+void tcp_fin(struct sock *sk)
{
struct tcp_sock *tp = tcp_sk(sk);
const struct dst_entry *dst;
--
1.8.5.3
next prev parent reply other threads:[~2014-03-21 13:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 13:32 [PATCH RFC 0/3] tcp: allow to repair a tcp connections in closing states Andrey Vagin
2014-03-21 13:32 ` [PATCH 1/3] tcp: allow to enable repair mode for sockets in any state Andrey Vagin
2014-03-24 22:47 ` Pavel Emelyanov
2014-03-21 13:33 ` [PATCH 2/3] tcp: check repair before fastopen in tcp_sendmsg Andrey Vagin
2014-03-21 13:33 ` Andrey Vagin [this message]
2014-03-21 14:04 ` [CRIU] [PATCH 3/3] tcp: add ability to restore a fin packet Christopher Covington
2014-03-24 23:29 ` [PATCH RFC 0/3] tcp: allow to repair a tcp connections in closing states David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395408781-8145-4-git-send-email-avagin@openvz.org \
--to=avagin@openvz.org \
--cc=criu@openvz.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gorcunov@openvz.org \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xemul@parallels.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).