netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Monam Agarwal <monamagarwal123@gmail.com>
To: davem@davemloft.net, ebiederm@xmission.com,
	nhorman@tuxdriver.com, cwang@twopensource.com, kaber@trash.net,
	antonio@meshcoding.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] net/core: Use RCU_INIT_POINTER(x, NULL) in netpoll.c
Date: Mon, 24 Mar 2014 00:42:46 +0530	[thread overview]
Message-ID: <1395601966-12490-1-git-send-email-monamagarwal123@gmail.com> (raw)

This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)

The rcu_assign_pointer() ensures that the initialization of a structure       
is carried out before storing a pointer to that structure. 
And in the case of the NULL pointer, there is no structure to initialize. 
So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
---
 net/core/netpoll.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/netpoll.c b/net/core/netpoll.c
index 7291dde..41c4e9c 100644
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -809,7 +809,7 @@ void __netpoll_cleanup(struct netpoll *np)
 		if (ops->ndo_netpoll_cleanup)
 			ops->ndo_netpoll_cleanup(np->dev);
 
-		rcu_assign_pointer(np->dev->npinfo, NULL);
+		RCU_INIT_POINTER(np->dev->npinfo, NULL);
 		call_rcu_bh(&npinfo->rcu, rcu_cleanup_netpoll_info);
 	}
 }
-- 
1.7.9.5

             reply	other threads:[~2014-03-23 19:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-23 19:12 Monam Agarwal [this message]
2014-03-24 11:11 ` [PATCH] net/core: Use RCU_INIT_POINTER(x, NULL) in netpoll.c Neil Horman
2014-03-24 13:14   ` Eric Dumazet
2014-03-24 13:49     ` Neil Horman
2014-03-27 21:28   ` Paul E. McKenney
2014-03-26  1:19 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395601966-12490-1-git-send-email-monamagarwal123@gmail.com \
    --to=monamagarwal123@gmail.com \
    --cc=antonio@meshcoding.com \
    --cc=cwang@twopensource.com \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=kaber@trash.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).