* [PATCH][net-next] ipv4: remove ipv4_ifdown_dst from route.c
@ 2014-03-24 3:03 roy.qing.li
2014-03-24 4:21 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: roy.qing.li @ 2014-03-24 3:03 UTC (permalink / raw)
To: netdev
From: Li RongQing <roy.qing.li@gmail.com>
ipv4_ifdown_dst does nothing after IPv4 route caches removal,
so we can remove it.
Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
---
net/ipv4/route.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 11e4384..57527ee 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -139,11 +139,6 @@ static void ip_do_redirect(struct dst_entry *dst, struct sock *sk,
struct sk_buff *skb);
static void ipv4_dst_destroy(struct dst_entry *dst);
-static void ipv4_dst_ifdown(struct dst_entry *dst, struct net_device *dev,
- int how)
-{
-}
-
static u32 *ipv4_cow_metrics(struct dst_entry *dst, unsigned long old)
{
WARN_ON(1);
@@ -162,7 +157,6 @@ static struct dst_ops ipv4_dst_ops = {
.mtu = ipv4_mtu,
.cow_metrics = ipv4_cow_metrics,
.destroy = ipv4_dst_destroy,
- .ifdown = ipv4_dst_ifdown,
.negative_advice = ipv4_negative_advice,
.link_failure = ipv4_link_failure,
.update_pmtu = ip_rt_update_pmtu,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][net-next] ipv4: remove ipv4_ifdown_dst from route.c
2014-03-24 3:03 [PATCH][net-next] ipv4: remove ipv4_ifdown_dst from route.c roy.qing.li
@ 2014-03-24 4:21 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-03-24 4:21 UTC (permalink / raw)
To: roy.qing.li; +Cc: netdev
From: roy.qing.li@gmail.com
Date: Mon, 24 Mar 2014 11:03:10 +0800
> From: Li RongQing <roy.qing.li@gmail.com>
>
> ipv4_ifdown_dst does nothing after IPv4 route caches removal,
> so we can remove it.
>
> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-24 4:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-24 3:03 [PATCH][net-next] ipv4: remove ipv4_ifdown_dst from route.c roy.qing.li
2014-03-24 4:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).