[PATCH] ixen-netback: fix trivial printf format build warning

[PATCH] ixen-netback: fix trivial printf format build warning

[SeongJae Park]

Fix following trivial build warning:

drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_dealloc_action’:
drivers/net/xen-netback/netback.c:1585:8: warning:
format ‘%x’ expects argument of type
 ‘unsigned int’, but argument 3 has type ‘long int’ [-Wformat=]
        gop - vif->tx_unmap_ops, ret);
        ^

Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
 drivers/net/xen-netback/netback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index 5a8c4a4..90001b3 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -1574,7 +1574,7 @@ static inline void xenvif_tx_dealloc_action(struct xenvif *vif)
 					vif->pages_to_unmap,
 					gop - vif->tx_unmap_ops);
 		if (ret) {
-			netdev_err(vif->dev, "Unmap fail: nr_ops %x ret %d\n",
+			netdev_err(vif->dev, "Unmap fail: nr_ops %lx ret %d\n",
 				   gop - vif->tx_unmap_ops, ret);
 			for (i = 0; i < gop - vif->tx_unmap_ops; ++i) {
 				if (gop[i].status != GNTST_okay)
-- 
1.8.3.2

Re: [PATCH] ixen-netback: fix trivial printf format build warning

[Ian Campbell]

On Wed, 2014-03-26 at 12:56 +0900, SeongJae Park wrote:
> Fix following trivial build warning:
> 
> drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_dealloc_action’:
> drivers/net/xen-netback/netback.c:1585:8: warning:
> format ‘%x’ expects argument of type
>  ‘unsigned int’, but argument 3 has type ‘long int’ [-Wformat=]
>         gop - vif->tx_unmap_ops, ret);
>         ^
> 
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>

Thanks but davem indicated overnight that he has already pushed a
suitable fix to net-next.

Ian.

Re: [PATCH] ixen-netback: fix trivial printf format build warning

[SeongJae Park]

Thank you for let me know kindly :)

On Wed, Mar 26, 2014 at 7:09 PM, Ian Campbell <Ian.Campbell@citrix.com> wrote:
> On Wed, 2014-03-26 at 12:56 +0900, SeongJae Park wrote:
>> Fix following trivial build warning:
>>
>> drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_dealloc_action’:
>> drivers/net/xen-netback/netback.c:1585:8: warning:
>> format ‘%x’ expects argument of type
>>  ‘unsigned int’, but argument 3 has type ‘long int’ [-Wformat=]
>>         gop - vif->tx_unmap_ops, ret);
>>         ^
>>
>> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
>
> Thanks but davem indicated overnight that he has already pushed a
> suitable fix to net-next.
>
> Ian.
>
>

Re: [PATCH] ixen-netback: fix trivial printf format build warning

[David Miller]

From: SeongJae Park <sj38.park@gmail.com>
Date: Wed, 26 Mar 2014 19:34:21 +0900

> Thank you for let me know kindly :)

Also your fix wasn't correct.

You changed the code to use %lx but the type isn't a long.

It's the difference between two pointers, which is ptrdiff_t.  The
proper printf format string for a hexadecimal ptrdiff_t is %tx

Re: [PATCH] ixen-netback: fix trivial printf format build warning

[SeongJae Park]

On Thu, Mar 27, 2014 at 3:46 AM, David Miller <davem@davemloft.net> wrote:
> From: SeongJae Park <sj38.park@gmail.com>
> Date: Wed, 26 Mar 2014 19:34:21 +0900
>
>> Thank you for let me know kindly :)
>
> Also your fix wasn't correct.
>
> You changed the code to use %lx but the type isn't a long.
>
> It's the difference between two pointers, which is ptrdiff_t.  The
> proper printf format string for a hexadecimal ptrdiff_t is %tx

You're right. Thanks for pointing that.