From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH net-next v3 1/2] net: tcp_ipv6 do some cleanup Date: Wed, 26 Mar 2014 13:40:43 -0700 Message-ID: <1395866443.3726.43.camel@joe-AO722> References: <1395642322-9404-1-git-send-email-wangyufen@huawei.com> <20140326.154255.1270995413257461102.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: wangyufen@huawei.com, netdev@vger.kernel.org To: David Miller Return-path: Received: from smtprelay0114.hostedemail.com ([216.40.44.114]:37710 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754582AbaCZUkq (ORCPT ); Wed, 26 Mar 2014 16:40:46 -0400 In-Reply-To: <20140326.154255.1270995413257461102.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2014-03-26 at 15:42 -0400, David Miller wrote: > From: Wangyufen > Date: Mon, 24 Mar 2014 14:25:21 +0800 > > > -static int tcp_v6_parse_md5_keys (struct sock *sk, char __user *optval, > > +static int tcp_v6_parse_md5_keys(struct sock *sk, char __user *optval, > > int optlen) > > If you change the first line, you must adjust the indentation of the second > line so that "int optlen)" begins precisely at the first column after the > openning parenthesis on the first line. checkpatch's --strict option emits a message about alignment issues like this. David, do you want the --strict option to be auto-enabled for patches of files in drivers/net and net/?