netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, Florian Fainelli <f.fainelli@gmail.com>
Subject: [PATCH net-next 12/14] r6040: remove empty MDIO bus reset function
Date: Wed, 26 Mar 2014 18:07:24 -0700	[thread overview]
Message-ID: <1395882446-552-13-git-send-email-f.fainelli@gmail.com> (raw)
In-Reply-To: <1395882446-552-1-git-send-email-f.fainelli@gmail.com>

r6040_mdiobus_reset() does nothing useful and is optional for the MDIO
bus code, so let's just remove it.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/net/ethernet/rdc/r6040.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/net/ethernet/rdc/r6040.c b/drivers/net/ethernet/rdc/r6040.c
index 819b74cefd64..cd045ecb9816 100644
--- a/drivers/net/ethernet/rdc/r6040.c
+++ b/drivers/net/ethernet/rdc/r6040.c
@@ -270,11 +270,6 @@ static int r6040_mdiobus_write(struct mii_bus *bus, int phy_addr,
 	return r6040_phy_write(ioaddr, phy_addr, reg, value);
 }
 
-static int r6040_mdiobus_reset(struct mii_bus *bus)
-{
-	return 0;
-}
-
 static void r6040_free_txbufs(struct net_device *dev)
 {
 	struct r6040_private *lp = netdev_priv(dev);
@@ -1191,7 +1186,6 @@ static int r6040_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 	lp->mii_bus->priv = dev;
 	lp->mii_bus->read = r6040_mdiobus_read;
 	lp->mii_bus->write = r6040_mdiobus_write;
-	lp->mii_bus->reset = r6040_mdiobus_reset;
 	lp->mii_bus->name = "r6040_eth_mii";
 	snprintf(lp->mii_bus->id, MII_BUS_ID_SIZE, "%s-%x",
 		dev_name(&pdev->dev), card_idx);
-- 
1.8.3.2

  parent reply	other threads:[~2014-03-27  1:08 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-27  1:07 [PATCH net-next 00/14] net: remove empty MDIO bus reset functions Florian Fainelli
2014-03-27  1:07 ` [PATCH net-next 01/14] net: greth: remove empty MDIO bus reset function Florian Fainelli
2014-03-27  1:07 ` [PATCH net-next 02/14] tg3: " Florian Fainelli
2014-03-27  1:07 ` [PATCH net-next 03/14] macb: " Florian Fainelli
2014-03-27  1:07 ` [PATCH net-next 04/14] dnet: " Florian Fainelli
2014-03-27  1:07 ` [PATCH net-next 05/14] net: ethoc: remove empty MDIO bus function Florian Fainelli
2014-03-27  1:07 ` [PATCH net-next 06/14] fec: " Florian Fainelli
2014-03-27  1:07 ` [PATCH net-next 07/14] fs_enet: " Florian Fainelli
2014-03-27  1:07 ` [PATCH net-next 08/14] net: mvmdio: remove empty MDIO bus reset function Florian Fainelli
2014-03-27  1:07 ` [PATCH net-next 09/14] net: emaclite: " Florian Fainelli
2014-03-27  1:07 ` [PATCH net-next 10/14] net: sun4i: " Florian Fainelli
2014-03-27  1:07 ` [PATCH net-next 11/14] net: ftgmac100: " Florian Fainelli
2014-03-27  1:07 ` Florian Fainelli [this message]
2014-03-27  1:07 ` [PATCH net-next 13/14] bfin_mac: " Florian Fainelli
2014-03-27  1:07 ` [PATCH net-next 14/14] Documentation: networking: phy.txt: MDIO bus reset is optional Florian Fainelli
2014-03-27  4:19 ` [PATCH net-next 00/14] net: remove empty MDIO bus reset functions David Miller
2014-03-27 17:17   ` Florian Fainelli
2014-03-27 18:40     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395882446-552-13-git-send-email-f.fainelli@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).