From: Paul Durrant <paul.durrant@citrix.com>
To: <xen-devel@lists.xen.org>, <netdev@vger.kernel.org>
Cc: Paul Durrant <paul.durrant@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Sander Eikelenboom <linux@eikelenboom.it>
Subject: [PATCH net v2 1/3] xen-netback: remove pointless clause from if statement
Date: Thu, 27 Mar 2014 12:56:11 +0000 [thread overview]
Message-ID: <1395924973-42904-2-git-send-email-paul.durrant@citrix.com> (raw)
In-Reply-To: <1395924973-42904-1-git-send-email-paul.durrant@citrix.com>
This patch removes a test in start_new_rx_buffer() that checks whether
a copy operation is less than MAX_BUFFER_OFFSET in length, since
MAX_BUFFER_OFFSET is defined to be PAGE_SIZE and the only caller of
start_new_rx_buffer() already limits copy operations to PAGE_SIZE or less.
Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
Cc: Sander Eikelenboom <linux@eikelenboom.it>
---
v2:
- Add BUG_ON() as suggested by Ian Campbell
drivers/net/xen-netback/netback.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index 438d0c0..72314c7 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -192,8 +192,8 @@ static bool start_new_rx_buffer(int offset, unsigned long size, int head)
* into multiple copies tend to give large frags their
* own buffers as before.
*/
- if ((offset + size > MAX_BUFFER_OFFSET) &&
- (size <= MAX_BUFFER_OFFSET) && offset && !head)
+ BUG_ON(size > MAX_BUFFER_OFFSET);
+ if ((offset + size > MAX_BUFFER_OFFSET) && offset && !head)
return true;
return false;
--
1.7.10.4
next prev parent reply other threads:[~2014-03-27 12:56 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 12:56 [PATCH net v2 0/3] xen-netback: fix rx slot estimation Paul Durrant
2014-03-27 12:56 ` Paul Durrant [this message]
2014-03-27 13:45 ` [PATCH net v2 1/3] xen-netback: remove pointless clause from if statement Sander Eikelenboom
2014-03-27 13:54 ` Paul Durrant
2014-03-27 14:02 ` Sander Eikelenboom
2014-03-27 14:09 ` Paul Durrant
2014-03-27 14:29 ` Sander Eikelenboom
2014-03-27 14:38 ` Paul Durrant
2014-03-27 16:46 ` Sander Eikelenboom
2014-03-27 16:54 ` Paul Durrant
2014-03-27 17:15 ` Sander Eikelenboom
2014-03-27 17:26 ` Paul Durrant
2014-03-27 18:34 ` Sander Eikelenboom
2014-03-27 19:22 ` [Xen-devel] " Sander Eikelenboom
2014-03-28 9:30 ` Paul Durrant
2014-03-28 9:39 ` Sander Eikelenboom
2014-03-28 9:47 ` Paul Durrant
2014-03-28 9:59 ` Sander Eikelenboom
2014-03-28 10:12 ` Paul Durrant
2014-03-28 10:36 ` Sander Eikelenboom
2014-03-28 10:01 ` David Laight
2014-03-28 10:20 ` Paul Durrant
2014-03-28 10:35 ` David Laight
2014-03-28 10:42 ` Sander Eikelenboom
2014-03-28 10:47 ` Paul Durrant
2014-03-28 10:53 ` Sander Eikelenboom
2014-03-28 11:11 ` David Laight
2014-03-28 11:35 ` Sander Eikelenboom
2014-03-28 10:44 ` Paul Durrant
2014-03-28 0:55 ` Sander Eikelenboom
2014-03-28 9:36 ` Paul Durrant
2014-03-28 9:46 ` Sander Eikelenboom
2014-03-27 14:00 ` Paul Durrant
2014-03-27 14:05 ` Sander Eikelenboom
2014-03-27 12:56 ` [PATCH net v2 2/3] xen-netback: worse-case estimate in xenvif_rx_action is underestimating Paul Durrant
2014-03-27 12:56 ` [PATCH net v2 3/3] xen-netback: BUG_ON in xenvif_rx_action() not catching overflow Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395924973-42904-2-git-send-email-paul.durrant@citrix.com \
--to=paul.durrant@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=linux@eikelenboom.it \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).