From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Anjali Singhai Jain <anjali.singhai@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
Catherine Sullivan <catherine.sullivan@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next v2 01/14] i40e: Delete ATR filter on RST
Date: Fri, 28 Mar 2014 07:08:02 -0700 [thread overview]
Message-ID: <1396015695-25283-2-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1396015695-25283-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Anjali Singhai Jain <anjali.singhai@intel.com>
We currently delete ATR filter on FIN alone, delete on RST as well.
Change-ID: Ie7cae5d1046b9d1d4a0d6ef5bdbf41224c3dade6
Signed-off-by: Anjali Singhai Jain <anjali.singhai@intel.com>
Signed-off-by: Catherine Sullivan <catherine.sullivan@intel.com>
Tested-by: Kavindya Deegala <kavindya.s.deegala@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_txrx.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
index 851f653..de25a32 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
@@ -1624,8 +1624,11 @@ static void i40e_atr(struct i40e_ring *tx_ring, struct sk_buff *skb,
tx_ring->atr_count++;
- /* sample on all syn/fin packets or once every atr sample rate */
- if (!th->fin && !th->syn && (tx_ring->atr_count < tx_ring->atr_sample_rate))
+ /* sample on all syn/fin/rst packets or once every atr sample rate */
+ if (!th->fin &&
+ !th->syn &&
+ !th->rst &&
+ (tx_ring->atr_count < tx_ring->atr_sample_rate))
return;
tx_ring->atr_count = 0;
@@ -1649,7 +1652,7 @@ static void i40e_atr(struct i40e_ring *tx_ring, struct sk_buff *skb,
dtype_cmd = I40E_TX_DESC_DTYPE_FILTER_PROG;
- dtype_cmd |= th->fin ?
+ dtype_cmd |= (th->fin || th->rst) ?
(I40E_FILTER_PROGRAM_DESC_PCMD_REMOVE <<
I40E_TXD_FLTR_QW1_PCMD_SHIFT) :
(I40E_FILTER_PROGRAM_DESC_PCMD_ADD_UPDATE <<
--
1.9.0
next prev parent reply other threads:[~2014-03-28 14:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 14:08 [net-next v2 00/14][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2014-03-28 14:08 ` Jeff Kirsher [this message]
2014-03-28 14:08 ` [net-next v2 02/14] i40evf: fix oops in watchdog handler Jeff Kirsher
2014-03-28 14:08 ` [net-next v2 03/14] i40e: Make the alloc and free queue vector calls orthogonal Jeff Kirsher
2014-03-28 14:08 ` [net-next v2 04/14] i40e: eeprom integrity check on load and empr Jeff Kirsher
2014-03-28 14:08 ` [net-next v2 05/14] i40e: Cleanup in FDIR SB ethtool code Jeff Kirsher
2014-03-28 14:08 ` [net-next v2 06/14] i40e: Add functionality for FD SB to drop packets Jeff Kirsher
2014-03-28 14:08 ` [net-next v2 07/14] i40evf: remove double space after return Jeff Kirsher
2014-03-28 19:58 ` Or Gerlitz
2014-03-31 17:48 ` Jesse Brandeburg
2014-03-31 18:18 ` Or Gerlitz
2014-03-31 18:24 ` Jeff Kirsher
2014-03-28 14:08 ` [net-next v2 08/14] i40e: check for netdev before debugfs use Jeff Kirsher
2014-03-28 14:08 ` [net-next v2 09/14] i40e/i40evf: Add an FD message level Jeff Kirsher
2014-03-28 14:08 ` [net-next v2 10/14] i40e: Use DEBUG_FD message level for an FD message Jeff Kirsher
2014-03-28 14:08 ` [net-next v2 11/14] e1000e: add timeout for TX HW time stamping work Jeff Kirsher
2014-03-28 14:08 ` [net-next v2 12/14] e1000e: remove redundant if clause from PTP work Jeff Kirsher
2014-03-28 14:08 ` [net-next v2 13/14] igb: never generate both software and hardware timestamps Jeff Kirsher
2014-03-28 14:08 ` [net-next v2 14/14] igb: fix race conditions on queuing skb for HW time stamp Jeff Kirsher
2014-03-28 18:45 ` [net-next v2 00/14][pull request] Intel Wired LAN Driver Updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396015695-25283-2-git-send-email-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=anjali.singhai@intel.com \
--cc=catherine.sullivan@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).