From: Joe Perches <joe@perches.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: Re: [PATCH net-next 05/17] ixgb: remove open-coded skb_cow_head.
Date: Sat, 29 Mar 2014 06:00:19 -0700 [thread overview]
Message-ID: <1396098019.3616.1.camel@joe-AO722> (raw)
In-Reply-To: <1396097224.3122.1.camel@joe-AO722>
On Sat, 2014-03-29 at 05:47 -0700, Joe Perches wrote:
> On Sat, 2014-03-29 at 12:26 +0100, Francois Romieu wrote:
> > struct ixgb_adapter *adapter, struct sk_buff *skb)
> > if (likely(skb_is_gso(skb))) {
> > struct ixgb_buffer *buffer_info;
> > struct iphdr *iph;
> > + int err;
> >
> > - if (skb_header_cloned(skb)) {
> > - err = pskb_expand_head(skb, 0, 0, GFP_ATOMIC);
> > - if (err)
> > - return err;
> > - }
> > + err = skb_cow_head(skb, 0);
> > + if (err < 0)
> > + return err
>
> It seems in many instances you're adding
> an unnecessary declaration of err that
> shadows an already declared err
I take back the many. This seems to be the only one.
next prev parent reply other threads:[~2014-03-29 13:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-29 11:26 [PATCH net-next 00/17] remove open-coded skb_cow_head Francois Romieu
2014-03-29 11:26 ` [PATCH net-next 01/17] atl1: " Francois Romieu
2014-03-29 11:26 ` [PATCH net-next 02/17] atl1c: " Francois Romieu
2014-03-29 11:26 ` [PATCH net-next 03/17] atl1e: " Francois Romieu
2014-03-29 11:26 ` [PATCH net-next 04/17] igb: " Francois Romieu
2014-03-29 19:03 ` Jeff Kirsher
2014-03-29 11:26 ` [PATCH net-next 05/17] ixgb: " Francois Romieu
[not found] ` <1396097224.3122.1.camel@joe-AO722>
2014-03-29 13:00 ` Joe Perches [this message]
2014-03-29 19:03 ` Jeff Kirsher
2014-03-29 11:26 ` [PATCH net-next 06/17] ixgbvf: " Francois Romieu
2014-03-29 19:03 ` Jeff Kirsher
2014-03-29 19:31 ` Jeff Kirsher
2014-03-29 11:26 ` [PATCH net-next 07/17] ixgbe: " Francois Romieu
2014-03-29 19:03 ` Jeff Kirsher
2014-03-29 11:26 ` [PATCH net-next 08/17] ixgbevf: " Francois Romieu
2014-03-29 19:03 ` Jeff Kirsher
2014-03-29 11:26 ` [PATCH net-next 09/17] e1000: " Francois Romieu
2014-03-29 19:04 ` Jeff Kirsher
2014-03-29 11:26 ` [PATCH net-next 10/17] e1000e: " Francois Romieu
2014-03-29 19:04 ` Jeff Kirsher
2014-03-29 11:26 ` [PATCH net-next 11/17] i40e: " Francois Romieu
2014-03-29 19:04 ` Jeff Kirsher
2014-03-29 11:26 ` [PATCH net-next 12/17] i40evf: " Francois Romieu
2014-03-29 19:04 ` Jeff Kirsher
2014-03-29 11:26 ` [PATCH net-next 13/17] jme: " Francois Romieu
2014-03-29 11:26 ` [PATCH net-next 14/17] qlge: " Francois Romieu
2014-03-29 11:26 ` [PATCH net-next 15/17] bna: " Francois Romieu
2014-03-29 11:26 ` [PATCH net-next 16/17] tg3: " Francois Romieu
2014-03-29 11:26 ` [PATCH net-next 17/17] wimax/i2400m: " Francois Romieu
2014-03-29 21:50 ` [PATCH net-next 00/17] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396098019.3616.1.camel@joe-AO722 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).