From: Toshiaki Makita <toshiaki.makita1@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Vlad Yasevich <vyasevic@redhat.com>,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH net] bridge: Fix memory leak in br_dev_xmit
Date: Sun, 30 Mar 2014 11:41:35 +0900 [thread overview]
Message-ID: <1396147295.2182.12.camel@localhost.localdomain> (raw)
In-Reply-To: <1396078847.1756.1.camel@localhost.localdomain>
On Sat, 2014-03-29 at 16:40 +0900, Toshiaki Makita wrote:
> On Fri, 2014-03-28 at 09:34 -0700, Stephen Hemminger wrote:
> > On Fri, 28 Mar 2014 15:21:19 +0900
> > Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp> wrote:
> >
> > > When a frame is rejected by br_allowed_ingress(), the skb is not freed.
> > >
> ...
> > Increment dev->tx_dropped?
>
> OK, I'll rework it.
After investigating bridge codes, I found br_cpu_netstats doesn't have
tx_dropped field.
I'm thinking about adding that field, but it seems to be appropriate for
net-next. I'm resending this patch as is for now.
Thanks,
Toshiaki Makita
prev parent reply other threads:[~2014-03-30 2:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 6:21 [PATCH net] bridge: Fix memory leak in br_dev_xmit Toshiaki Makita
2014-03-28 16:34 ` Stephen Hemminger
2014-03-29 7:40 ` Toshiaki Makita
2014-03-30 2:41 ` Toshiaki Makita [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396147295.2182.12.camel@localhost.localdomain \
--to=toshiaki.makita1@gmail.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).