Re: [PATCH net-next 3/4] ixgbe: clean up rx time stamping code

[Jeff Kirsher <jeffrey.t.kirsher@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 987 bytes --]

On Wed, 2014-04-02 at 02:52 +0200, Jakub Kicinski wrote:
> Time stamping resources are per-interface so there is no need
> to keep separate last_rx_timestamp for each rx ring, move
> last_rx_timestamp to the adapter structure.
> 
> With last_rx_timestamp inside adapter, ixgbe_ptp_rx_hwtstamp()
> inline function is reduced to a single if statement so it is
> no longer necessary. If statement is placed directly in
> ixgbe_process_skb_fields() fixing likely/unlikely marking.
> 
> Checks for q_vector or adapter to be NULL are superfluous.
> 
> Comment about taking I/O hit is a leftover from previous design.
> 
> Signed-off-by: Jakub Kicinski <kubakici@wp.pl>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe.h      | 21 ++--------------
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |  3 ++-
>  drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c  | 36
> ++++++++-------------------
>  3 files changed, 15 insertions(+), 45 deletions(-)

Added to my queue, thanks!

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]