* [PATCH v3 3/5] bonding: Initialize the ALB work queue for lb mode only.
@ 2014-04-02 7:00 Mahesh Bandewar
2014-04-02 11:03 ` Eric Dumazet
0 siblings, 1 reply; 2+ messages in thread
From: Mahesh Bandewar @ 2014-04-02 7:00 UTC (permalink / raw)
To: Jay Vosburgh, Veaceslav Falico, Andy Gospodarek, David Miller
Cc: netdev, Mahesh Bandewar, Eric Dumazet, Maciej Zenczykowski
micro change to initialize / cancel the ALB work queue only
if the mode selected is ALB or TLB.
Change-Id: I27a6cf65f72819889bf15b68f6ef4fca7d617186
Signed-off-by: Mahesh Bandewar <maheshb@google.com>
---
v2:
Rebase
v3:
Rebase
drivers/net/bonding/bond_main.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 6e96d510bc8d..676db41b98bc 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -3046,7 +3046,8 @@ static void bond_work_init_all(struct bonding *bond)
{
INIT_DELAYED_WORK(&bond->mcast_work,
bond_resend_igmp_join_requests_delayed);
- INIT_DELAYED_WORK(&bond->alb_work, bond_alb_monitor);
+ if (bond_is_lb(bond))
+ INIT_DELAYED_WORK(&bond->alb_work, bond_alb_monitor);
INIT_DELAYED_WORK(&bond->mii_work, bond_mii_monitor);
if (bond->params.mode == BOND_MODE_ACTIVEBACKUP)
INIT_DELAYED_WORK(&bond->arp_work, bond_activebackup_arp_mon);
@@ -3059,7 +3060,8 @@ static void bond_work_cancel_all(struct bonding *bond)
{
cancel_delayed_work_sync(&bond->mii_work);
cancel_delayed_work_sync(&bond->arp_work);
- cancel_delayed_work_sync(&bond->alb_work);
+ if (bond_is_lb(bond))
+ cancel_delayed_work_sync(&bond->alb_work);
cancel_delayed_work_sync(&bond->ad_work);
cancel_delayed_work_sync(&bond->mcast_work);
}
--
1.9.1.423.g4596e3a
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3 3/5] bonding: Initialize the ALB work queue for lb mode only.
2014-04-02 7:00 [PATCH v3 3/5] bonding: Initialize the ALB work queue for lb mode only Mahesh Bandewar
@ 2014-04-02 11:03 ` Eric Dumazet
0 siblings, 0 replies; 2+ messages in thread
From: Eric Dumazet @ 2014-04-02 11:03 UTC (permalink / raw)
To: Mahesh Bandewar
Cc: Jay Vosburgh, Veaceslav Falico, Andy Gospodarek, David Miller,
netdev, Eric Dumazet, Maciej Zenczykowski
On Wed, 2014-04-02 at 00:00 -0700, Mahesh Bandewar wrote:
> micro change to initialize / cancel the ALB work queue only
> if the mode selected is ALB or TLB.
>
> Change-Id: I27a6cf65f72819889bf15b68f6ef4fca7d617186
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
> ---
> v2:
> Rebase
> v3:
> Rebase
>
> drivers/net/bonding/bond_main.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 6e96d510bc8d..676db41b98bc 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -3046,7 +3046,8 @@ static void bond_work_init_all(struct bonding *bond)
> {
> INIT_DELAYED_WORK(&bond->mcast_work,
> bond_resend_igmp_join_requests_delayed);
> - INIT_DELAYED_WORK(&bond->alb_work, bond_alb_monitor);
> + if (bond_is_lb(bond))
> + INIT_DELAYED_WORK(&bond->alb_work, bond_alb_monitor);
> INIT_DELAYED_WORK(&bond->mii_work, bond_mii_monitor);
> if (bond->params.mode == BOND_MODE_ACTIVEBACKUP)
> INIT_DELAYED_WORK(&bond->arp_work, bond_activebackup_arp_mon);
> @@ -3059,7 +3060,8 @@ static void bond_work_cancel_all(struct bonding *bond)
> {
> cancel_delayed_work_sync(&bond->mii_work);
> cancel_delayed_work_sync(&bond->arp_work);
> - cancel_delayed_work_sync(&bond->alb_work);
> + if (bond_is_lb(bond))
> + cancel_delayed_work_sync(&bond->alb_work);
> cancel_delayed_work_sync(&bond->ad_work);
> cancel_delayed_work_sync(&bond->mcast_work);
> }
I would prefer you drop this patch.
As I said, there is no gain but potential troubles with this,
bonding driver is heavily changed by lot of people.
Its not like we setup/dismantle thousand of bonding devices per second
on a host.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-02 11:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-02 7:00 [PATCH v3 3/5] bonding: Initialize the ALB work queue for lb mode only Mahesh Bandewar
2014-04-02 11:03 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).