From: Wei Yang <weiyang@linux.vnet.ibm.com>
To: fan.du@windriver.com, netdev@vger.kernel.org
Cc: davem@davemloft.net, Wei Yang <weiyang@linux.vnet.ibm.com>
Subject: [Patch net-next] pktgen: small code cleanup
Date: Wed, 2 Apr 2014 16:24:51 +0800 [thread overview]
Message-ID: <1396427091-8230-1-git-send-email-weiyang@linux.vnet.ibm.com> (raw)
Print the warning when the format is not correct.
Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com>
---
net/core/pktgen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index fdac61c..89d33c2 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -1767,7 +1767,7 @@ static ssize_t pktgen_thread_write(struct file *file,
char *pg_result;
if (count < 1) {
- // sprintf(pg_result, "Wrong command format");
+ pr_warn("WARNING: Wrong command format in %s\n", __func__);
return -EINVAL;
}
--
1.7.9.5
next reply other threads:[~2014-04-02 8:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 8:24 Wei Yang [this message]
2014-04-03 17:35 ` [Patch net-next] pktgen: small code cleanup David Miller
2014-04-04 13:29 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396427091-8230-1-git-send-email-weiyang@linux.vnet.ibm.com \
--to=weiyang@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=fan.du@windriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).